From: Stephen Hemminger <shemminger@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: bugme-daemon@bugzilla.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()
Date: Wed, 16 Aug 2006 11:06:31 -0700 [thread overview]
Message-ID: <20060816110631.42b20c77@localhost.localdomain> (raw)
In-Reply-To: <20060816012900.GA23430@gondor.apana.org.au>
On Wed, 16 Aug 2006 11:29:00 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Tue, Aug 15, 2006 at 11:29:59AM -0700, bugme-daemon@bugzilla.kernel.org wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=6936
>
> It's actually a bug in the bridging code :)
>
> [BRIDGE]: Disable SG/GSO if TX checksum is off
>
> When the bridge recomputes features, it does not maintain the
> constraint that SG/GSO must be off if TX checksum is off.
> This patch adds that constraint.
>
> On a completely unrelated note, I've also added TSO6 and TSO_ECN
> feature bits if GSO is enabled on the underlying device through
> the new NETIF_F_GSO_SOFTWARE macro.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Cheers,
agree. I assume this came in with the new GSO for 2.6.18 or do we need
to fix 2.6.17 as well.
next prev parent reply other threads:[~2006-08-16 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608151829.k7FITxKM006438@fire-2.osdl.org>
2006-08-16 1:29 ` [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help() Herbert Xu
2006-08-16 18:06 ` Stephen Hemminger [this message]
2006-08-17 0:13 ` Herbert Xu
2006-08-18 1:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060816110631.42b20c77@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).