From: Stephen Hemminger <shemminger@osdl.org>
To: "Beschorner Daniel" <Daniel.Beschorner@facton.com>
Cc: "Krzysztof Oledzki" <olel@ans.pl>, <netdev@vger.kernel.org>
Subject: Re: skge crashes
Date: Wed, 16 Aug 2006 20:39:03 -0700 [thread overview]
Message-ID: <20060816203903.3a7b1d32@localhost.localdomain> (raw)
In-Reply-To: <664E3671B2B6DC439E0C9FFCF8E40CA205F501@exchange.I-BNEX>
possible PCI posting bug?
--- linux-2.6.orig/drivers/net/skge.c
+++ linux-2.6/drivers/net/skge.c
@@ -2745,7 +2745,7 @@ static int skge_poll(struct net_device *
spin_lock_irq(&hw->hw_lock);
hw->intr_mask |= rxirqmask[skge->port];
skge_write32(hw, B0_IMSK, hw->intr_mask);
- mmiowb();
+ skge_read32(hw, B0_IMSK);
spin_unlock_irq(&hw->hw_lock);
return 0;
@@ -2879,6 +2879,7 @@ static void skge_extirq(void *arg)
spin_lock_irq(&hw->hw_lock);
hw->intr_mask |= IS_EXT_REG;
skge_write32(hw, B0_IMSK, hw->intr_mask);
+ skge_read32(hw, B0_IMSK);
spin_unlock_irq(&hw->hw_lock);
}
@@ -2953,6 +2954,7 @@ static irqreturn_t skge_intr(int irq, vo
skge_error_irq(hw);
skge_write32(hw, B0_IMSK, hw->intr_mask);
+ skge_read32(hw, B0_IMSK);
spin_unlock(&hw->hw_lock);
return IRQ_HANDLED;
next prev parent reply other threads:[~2006-08-17 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 17:47 skge crashes Beschorner Daniel
2006-08-16 17:57 ` Stephen Hemminger
2006-08-16 21:54 ` Beschorner Daniel
2006-08-17 3:39 ` Stephen Hemminger [this message]
2006-08-18 8:56 ` Beschorner Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060816203903.3a7b1d32@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=Daniel.Beschorner@facton.com \
--cc=netdev@vger.kernel.org \
--cc=olel@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox