* Re: [PATCH 2/7] ip1000: remove some default phy params
2006-08-17 19:43 [PATCH 2/7] ip1000: remove some default phy params Jesse Huang
@ 2006-08-17 11:09 ` David Gómez
2006-08-18 6:18 ` Jesse Huang
0 siblings, 1 reply; 3+ messages in thread
From: David Gómez @ 2006-08-17 11:09 UTC (permalink / raw)
To: Jesse Huang; +Cc: romieu, penberg, akpm, dvrabel, linux-kernel, netdev
Hi Jesse,
On Aug 17 at 03:43:29, Jesse Huang wrote:
> From: Jesse Huang <jesse@icplus.com.tw>
>
> remove some default phy params
>
> Change Logs:
> remove some default phy params
First, thanks for finalling commiting this driver ;).
But please resend the patches with "Signed-off-by:"
line. I'm not much of a git hacker, but i think you
can use 'git-applymbox' to put a signedoff line in your
mbox-formatted patches.
regards,
--
David Gómez Jabber ID: davidge@jabber.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/7] ip1000: remove some default phy params
@ 2006-08-17 19:43 Jesse Huang
2006-08-17 11:09 ` David Gómez
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Huang @ 2006-08-17 19:43 UTC (permalink / raw)
To: romieu, penberg, akpm, dvrabel, linux-kernel, netdev, david,
jesse
From: Jesse Huang <jesse@icplus.com.tw>
remove some default phy params
Change Logs:
remove some default phy params
---
drivers/net/ipg.h | 54 +----------------------------------------------------
1 files changed, 1 insertions(+), 53 deletions(-)
af38044af640ea6997ad6ced277e5f42f8307d8d
diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
index 58b1417..9f841d2 100644
--- a/drivers/net/ipg.h
+++ b/drivers/net/ipg.h
@@ -919,59 +919,7 @@ unsigned short DefaultPhyParam[] = {
// 01/09/04 IP1000A v1-5 rev=0x41
(0x4100 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x42
- (0x4200 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x43
- (0x4300 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x44
- (0x4400 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x45
- (0x4500 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x46
- (0x4600 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x47
- (0x4700 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x48
- (0x4800 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x49
- (0x4900 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x4A
- (0x4A00 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x4B
- (0x4B00 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x4C
- (0x4C00 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x4D
- (0x4D00 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
- // 01/09/04 IP1000A v1-5 rev=0x4E
- (0x4E00 | (07 * 4)), 31, 0x0001, 27, 0x01e0, 31, 0x0002, 27, 0xeb8e, 31,
- 0x0000,
- 30, 0x005e, 9, 0x0700,
+ 30, 0x005e, 9, 0x0700,
0x0000
};
--
1.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/7] ip1000: remove some default phy params
2006-08-17 11:09 ` David Gómez
@ 2006-08-18 6:18 ` Jesse Huang
0 siblings, 0 replies; 3+ messages in thread
From: Jesse Huang @ 2006-08-18 6:18 UTC (permalink / raw)
To: David Gomez; +Cc: romieu, penberg, akpm, dvrabel, linux-kernel, netdev
Hi David:
Ok, I will add sign-off-by latter. Thanks for that.
Jesse Huang
----- Original Message -----
From: "David Gomez" <david@pleyades.net>
To: "Jesse Huang" <jesse@icplus.com.tw>
Cc: <romieu@fr.zoreil.com>; <penberg@cs.Helsinki.FI>; <akpm@osdl.org>;
<dvrabel@cantab.net>; <linux-kernel@vger.kernel.org>;
<netdev@vger.kernel.org>
Sent: Thursday, August 17, 2006 7:09 PM
Subject: Re: [PATCH 2/7] ip1000: remove some default phy params
Hi Jesse,
On Aug 17 at 03:43:29, Jesse Huang wrote:
> From: Jesse Huang <jesse@icplus.com.tw>
>
> remove some default phy params
>
> Change Logs:
> remove some default phy params
First, thanks for finalling commiting this driver ;).
But please resend the patches with "Signed-off-by:"
line. I'm not much of a git hacker, but i think you
can use 'git-applymbox' to put a signedoff line in your
mbox-formatted patches.
regards,
--
David Gomez Jabber ID:
davidge@jabber.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-18 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-17 19:43 [PATCH 2/7] ip1000: remove some default phy params Jesse Huang
2006-08-17 11:09 ` David Gómez
2006-08-18 6:18 ` Jesse Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).