From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Nottingham Subject: Re: bonding: cannot remove certain named devices Date: Thu, 17 Aug 2006 22:20:57 -0400 Message-ID: <20060818022057.GA27076@nostromo.devel.redhat.com> References: <20060816133811.GA26471@nostromo.devel.redhat.com> <1155799783.7566.5.camel@capoeira> <20060817.162340.74748342.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xavier.bestel@free.fr, 7eggert@gmx.de, cate@debian.org, 7eggert@elstempel.de, shemminger@osdl.org, mitch.a.williams@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:13025 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932295AbWHRCVi (ORCPT ); Thu, 17 Aug 2006 22:21:38 -0400 To: David Miller Content-Disposition: inline In-Reply-To: <20060817.162340.74748342.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller (davem@davemloft.net) said: > From: Xavier Bestel > Date: Thu, 17 Aug 2006 09:29:43 +0200 > > > Why not simply retricting chars to isalnum() ones ? > > As Bill said that would block things like "-" and "_" which are fine. > > Bill also mentioned something about "breaking configs going back to > 2.4.x" which is bogus because nothing broke when we started blocking > "/" and "." and ".." in networking device names during the addition of > sysfs support for net devices. I was mainly referring to if we started to filter it out to isalnum() - spaces/tab/CR etc. certainly could be filtered. (No idea what would happen with unicode nbsp or other silly things.) Bill