netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jouni Malinen" <jkm@devicescape.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Simon Barber <simon@devicescape.com>,
	Jiri Benc <jbenc@suse.cz>
Subject: Re: [clarification request] ieee80211_tx_control.pkt_type
Date: Fri, 18 Aug 2006 07:33:21 -0700	[thread overview]
Message-ID: <20060818143321.GA23446@instant802.com> (raw)
In-Reply-To: <1155901317.22520.2.camel@ux156>

On Fri, Aug 18, 2006 at 01:41:57PM +0200, Johannes Berg wrote:

> I was pondering the ieee80211_tx_control type and don't see anyone using
> the pkt_type field. d80211 makes great effort to have it correct, but no
> driver uses it.
> 
> Hence, my question: What is the purpose of this field? Under what
> circumstances would a driver have to know this? Especially considering
> that it's only "normal" vs. "probe response"...

Some hardware designs require this configuration for TX frames. It is
used to select whether some of the fields are being filled in hardware
(e.g., timestamp for Probe Response). This would only be needed for AP
mode and IBSS (adhoc), so it is possible that not all low-level dirvers
have yet been implemented to support such operation.

This pkt_type was added at generic 802.11 layer in order to avoid
forcing the low-level driver to even look at the 802.11 header when
queuing the frame for transmission. Taken into account how simple
operation it is to get the type and subtype from the frame control
field, this tx ctrl pkt_type could be removed, if desired. However, it
was added there for a reason.

-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2006-08-18 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-18 11:41 [clarification request] ieee80211_tx_control.pkt_type Johannes Berg
2006-08-18 14:33 ` Jouni Malinen [this message]
2006-08-18 14:50   ` Johannes Berg
2006-08-18 16:25     ` Simon Barber
2006-08-21  7:21       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060818143321.GA23446@instant802.com \
    --to=jkm@devicescape.com \
    --cc=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    --cc=simon@devicescape.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).