From: Michael Buesch <mb@bu3sch.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: [PATCH] skge: fix swapped kcalloc() arguments
Date: Fri, 18 Aug 2006 23:54:52 +0200 [thread overview]
Message-ID: <200608182354.52537.mb@bu3sch.de> (raw)
Hey Stephen,
Please push the following fix upstream.
--
/**
* kcalloc - allocate memory for an array. The memory is set to zero.
* @n: number of elements.
* @size: element size.
* @flags: the type of memory to allocate.
*/
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: linux-2.6/drivers/net/skge.c
===================================================================
--- linux-2.6.orig/drivers/net/skge.c 2006-08-02 22:57:23.000000000 +0200
+++ linux-2.6/drivers/net/skge.c 2006-08-18 23:52:43.000000000 +0200
@@ -731,7 +731,7 @@
struct skge_element *e;
int i;
- ring->start = kcalloc(sizeof(*e), ring->count, GFP_KERNEL);
+ ring->start = kcalloc(ring->count, sizeof(*e), GFP_KERNEL);
if (!ring->start)
return -ENOMEM;
--
Greetings Michael.
next reply other threads:[~2006-08-18 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 21:54 Michael Buesch [this message]
2006-08-18 22:33 ` [PATCH] skge: fix swapped kcalloc() arguments Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608182354.52537.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).