* [PATCH] skge: fix swapped kcalloc() arguments
@ 2006-08-18 21:54 Michael Buesch
2006-08-18 22:33 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2006-08-18 21:54 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Hey Stephen,
Please push the following fix upstream.
--
/**
* kcalloc - allocate memory for an array. The memory is set to zero.
* @n: number of elements.
* @size: element size.
* @flags: the type of memory to allocate.
*/
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: linux-2.6/drivers/net/skge.c
===================================================================
--- linux-2.6.orig/drivers/net/skge.c 2006-08-02 22:57:23.000000000 +0200
+++ linux-2.6/drivers/net/skge.c 2006-08-18 23:52:43.000000000 +0200
@@ -731,7 +731,7 @@
struct skge_element *e;
int i;
- ring->start = kcalloc(sizeof(*e), ring->count, GFP_KERNEL);
+ ring->start = kcalloc(ring->count, sizeof(*e), GFP_KERNEL);
if (!ring->start)
return -ENOMEM;
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] skge: fix swapped kcalloc() arguments
2006-08-18 21:54 [PATCH] skge: fix swapped kcalloc() arguments Michael Buesch
@ 2006-08-18 22:33 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2006-08-18 22:33 UTC (permalink / raw)
To: Michael Buesch; +Cc: netdev
On Fri, 18 Aug 2006 23:54:52 +0200
Michael Buesch <mb@bu3sch.de> wrote:
> Hey Stephen,
>
> Please push the following fix upstream.
>
ok, but it can't make much difference, unless someone did something
like try to set ring->count to zero.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-18 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-18 21:54 [PATCH] skge: fix swapped kcalloc() arguments Michael Buesch
2006-08-18 22:33 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).