netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: netdev@vger.kernel.org
Cc: bcm43xx-dev@lists.berlios.de
Subject: wireless: NETDEV_TX_LOCKED, use it or not?
Date: Sat, 19 Aug 2006 12:22:42 +0200	[thread overview]
Message-ID: <200608191222.42899.mb@bu3sch.de> (raw)

Hi,

I am currently wondering, if we should use NETDEV_TX_LOCKED
in the bcm43xx wireless net driver.

I currently don't have an SMP machine with a bcm43xx card
running, so I can't use benchmarks to find out.

There are various things to consider:
* The RX and TX-status paths, which also must take the spinlock
  aren't more expensive than on a normal Ethernet card (at least
  with d80211 stack).
* But the retry-path, when a NETDEV_TX_LOCKED is returned is
  slightly more expensive.

Well, the question is: Is it worth to return NETDEV_TX_LOCKED
on spinlock contention, or is it better to spin?
Is NETDEV_TX_LOCKED only desired on gigabit ethernet?

Thanks.

-- 
Greetings Michael.

                 reply	other threads:[~2006-08-19 10:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608191222.42899.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).