netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denis Vlasenko <vda.linux@googlemail.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: 800+ byte inlines in include/net/pkt_act.h
Date: Sun, 20 Aug 2006 19:33:10 +0200	[thread overview]
Message-ID: <200608201933.10293.vda.linux@googlemail.com> (raw)

Hi,

include/net/pkt_act.h plays a game of inlines
which are kind of "templatized", like this:

act_ipt.c:

/* ovewrride the defaults */
#define tcf_st          tcf_ipt
#define tcf_t_lock      ipt_lock
#define tcf_ht          tcf_ipt_ht
#define CONFIG_NET_ACT_INIT
#include <net/pkt_act.h>

This results in code duplication. For example,
tcf_generic_walker() is duplicated four times.
On i386 it is about 4*800 bytes in text section.
Other inlines are a bit smaller but still are substantial.
--
vda

             reply	other threads:[~2006-08-20 17:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-20 17:33 Denis Vlasenko [this message]
2006-08-21 12:26 ` 800+ byte inlines in include/net/pkt_act.h jamal
2006-08-21 23:38   ` David Miller
2006-08-22 13:45     ` jamal
2006-08-22  6:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608201933.10293.vda.linux@googlemail.com \
    --to=vda.linux@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).