From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: vda.linux@googlemail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: 800+ byte inlines in include/net/pkt_act.h
Date: Mon, 21 Aug 2006 16:38:01 -0700 (PDT) [thread overview]
Message-ID: <20060821.163801.15260979.davem@davemloft.net> (raw)
In-Reply-To: <1156163160.5126.47.camel@jzny2>
From: jamal <hadi@cyberus.ca>
Date: Mon, 21 Aug 2006 08:26:00 -0400
> As per last discussion, either Patrick McHardy or myself are going
> to work on it - at some point. Please be patient. The other
> alternative is: you fix it and send patches.
I'm working on it right now. This code is really gross and needs
to be fixed immediately.
What I'll do is define a "struct tcf_common" and have the generic
interfaces take that as well as a "struct tcf_hashinfo *" parameter to
deal with the individual hash tables.
We define all of this templated stuff then don't even use it in
act_police.c, we just duplicate everything!
Absolutely unbelievable.
next prev parent reply other threads:[~2006-08-21 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 17:33 800+ byte inlines in include/net/pkt_act.h Denis Vlasenko
2006-08-21 12:26 ` jamal
2006-08-21 23:38 ` David Miller [this message]
2006-08-22 13:45 ` jamal
2006-08-22 6:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821.163801.15260979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).