netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro
@ 2006-08-21  3:33 Zhu Yi
  2006-08-21 10:39 ` Dan Williams
  2006-08-21 13:02 ` Christoph Hellwig
  0 siblings, 2 replies; 4+ messages in thread
From: Zhu Yi @ 2006-08-21  3:33 UTC (permalink / raw)
  To: netdev, John W. Linville

Add IEEE80211_API_VERSION macro so that drivers are able to check it
during compile time. This feature is useful to make backward IEEE80211
compatibilities for wireless drivers.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>

---

 include/net/ieee80211.h |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

29be0803256136011dd5c3b62e3eb9f782e57dbd
diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h
index b174ebb..83e06aa 100644
--- a/include/net/ieee80211.h
+++ b/include/net/ieee80211.h
@@ -29,7 +29,17 @@
 #include <linux/kernel.h>	/* ARRAY_SIZE */
 #include <linux/wireless.h>
 
-#define IEEE80211_VERSION "git-1.1.13"
+#define IEEE80211_VERSION_MAJOR 1
+#define IEEE80211_VERSION_API 2
+#define IEEE80211_VERSION_MINOR 15
+#define IEEE80211_VERSION_CODE IEEE80211_VERSION_MAJOR * 65536 + \
+			       IEEE80211_VERSION_API * 256 + \
+			       IEEE80211_VERSION_MINOR
+#define _STRX(x) #x
+#define _VERSION_STR(a,b,c) _STRX(a) "." _STRX(b) "." _STRX(c)
+#define IEEE80211_VERSION _VERSION_STR(IEEE80211_VERSION_MAJOR,\
+				       IEEE80211_VERSION_API, \
+				       IEEE80211_VERSION_MINOR)
 
 #define IEEE80211_DATA_LEN		2304
 /* Maximum size for the MA-UNITDATA primitive, 802.11 standard section
-- 
1.2.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro
  2006-08-21  3:33 [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro Zhu Yi
@ 2006-08-21 10:39 ` Dan Williams
  2006-08-22  4:50   ` Zhu Yi
  2006-08-21 13:02 ` Christoph Hellwig
  1 sibling, 1 reply; 4+ messages in thread
From: Dan Williams @ 2006-08-21 10:39 UTC (permalink / raw)
  To: yi.zhu; +Cc: netdev, John W. Linville

On Mon, 2006-08-21 at 11:33 +0800, Zhu Yi wrote:
> Add IEEE80211_API_VERSION macro so that drivers are able to check it
> during compile time. This feature is useful to make backward IEEE80211
> compatibilities for wireless drivers.

Per my other mail, what exactly has changed and must be checked?  The
SIOCGIWFREQ stuff?

Dan

> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> 
> ---
> 
>  include/net/ieee80211.h |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> 29be0803256136011dd5c3b62e3eb9f782e57dbd
> diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h
> index b174ebb..83e06aa 100644
> --- a/include/net/ieee80211.h
> +++ b/include/net/ieee80211.h
> @@ -29,7 +29,17 @@
>  #include <linux/kernel.h>	/* ARRAY_SIZE */
>  #include <linux/wireless.h>
>  
> -#define IEEE80211_VERSION "git-1.1.13"
> +#define IEEE80211_VERSION_MAJOR 1
> +#define IEEE80211_VERSION_API 2
> +#define IEEE80211_VERSION_MINOR 15
> +#define IEEE80211_VERSION_CODE IEEE80211_VERSION_MAJOR * 65536 + \
> +			       IEEE80211_VERSION_API * 256 + \
> +			       IEEE80211_VERSION_MINOR
> +#define _STRX(x) #x
> +#define _VERSION_STR(a,b,c) _STRX(a) "." _STRX(b) "." _STRX(c)
> +#define IEEE80211_VERSION _VERSION_STR(IEEE80211_VERSION_MAJOR,\
> +				       IEEE80211_VERSION_API, \
> +				       IEEE80211_VERSION_MINOR)
>  
>  #define IEEE80211_DATA_LEN		2304
>  /* Maximum size for the MA-UNITDATA primitive, 802.11 standard section


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro
  2006-08-21  3:33 [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro Zhu Yi
  2006-08-21 10:39 ` Dan Williams
@ 2006-08-21 13:02 ` Christoph Hellwig
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2006-08-21 13:02 UTC (permalink / raw)
  To: Zhu Yi; +Cc: netdev, John W. Linville

On Mon, Aug 21, 2006 at 11:33:22AM +0800, Zhu Yi wrote:
> Add IEEE80211_API_VERSION macro so that drivers are able to check it
> during compile time. This feature is useful to make backward IEEE80211
> compatibilities for wireless drivers.

NACK.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro
  2006-08-21 10:39 ` Dan Williams
@ 2006-08-22  4:50   ` Zhu Yi
  0 siblings, 0 replies; 4+ messages in thread
From: Zhu Yi @ 2006-08-22  4:50 UTC (permalink / raw)
  To: Dan Williams; +Cc: netdev, John W. Linville

On Mon, 2006-08-21 at 06:39 -0400, Dan Williams wrote:
> Per my other mail, what exactly has changed and must be checked?  The
> SIOCGIWFREQ stuff?

The prototype of ieee80211_tx_frame() changed. It used to have 3
parameters. Now it has 5.

Thanks,
-yi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-08-22  4:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-21  3:33 [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro Zhu Yi
2006-08-21 10:39 ` Dan Williams
2006-08-22  4:50   ` Zhu Yi
2006-08-21 13:02 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).