netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms
@ 2006-08-21  3:37 Zhu Yi
  2006-08-21  9:52 ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Zhu Yi @ 2006-08-21  3:37 UTC (permalink / raw)
  To: netdev, John W. Linville

ipw2100 driver doesn't support big endian by now.

Signed-off-by: Karol Lewandowski <kl@jasmine.eu.org>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>

---

 drivers/net/wireless/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

97b35942893f7999dadcd18d8801ac460f65ce67
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index a8ffd78..513bfc3 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -146,7 +146,7 @@ comment "Wireless 802.11b ISA/PCI cards 
 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI
+	depends on NET_RADIO && PCI && (X86 || X86_64 || IA64 || BROKEN)
 	select FW_LOADER
 	select IEEE80211
 	---help---
-- 
1.2.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms
  2006-08-21  3:37 [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms Zhu Yi
@ 2006-08-21  9:52 ` Christoph Hellwig
  2006-08-22  4:50   ` Zhu Yi
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2006-08-21  9:52 UTC (permalink / raw)
  To: Zhu Yi; +Cc: netdev, John W. Linville

On Mon, Aug 21, 2006 at 11:37:49AM +0800, Zhu Yi wrote:
> ipw2100 driver doesn't support big endian by now.

NACK.  Fix it instead.

>  	tristate "Intel PRO/Wireless 2100 Network Connection"
> -	depends on NET_RADIO && PCI
> +	depends on NET_RADIO && PCI && (X86 || X86_64 || IA64 || BROKEN)

There's a lot more little endian platforms than just the intel ones, aswell.

It seems you're totally unsuitable as a driver or subsystem maintainer if
you favour you own employer so much.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms
  2006-08-21  9:52 ` Christoph Hellwig
@ 2006-08-22  4:50   ` Zhu Yi
  2006-08-22  9:11     ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Zhu Yi @ 2006-08-22  4:50 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: netdev, John W. Linville

On Mon, 2006-08-21 at 10:52 +0100, Christoph Hellwig wrote:
> There's a lot more little endian platforms than just the intel ones,
> aswell.
> 
> It seems you're totally unsuitable as a driver or subsystem maintainer
> if you favour you own employer so much.

I'm not saying I'm not going to support it in the future. But currently
ipw2100 doesn't support big endian machines is the truth. One reason is
because I don't have such a box with an ipw2100 card. If you or someone
has such a platform and is willing to try patches for me, I'm happy to
get this done. That's why the ipw2200 driver has the BE supported.

Thanks,
-yi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms
  2006-08-22  4:50   ` Zhu Yi
@ 2006-08-22  9:11     ` Christoph Hellwig
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2006-08-22  9:11 UTC (permalink / raw)
  To: Zhu Yi; +Cc: Christoph Hellwig, netdev, John W. Linville

On Tue, Aug 22, 2006 at 12:50:30PM +0800, Zhu Yi wrote:
> I'm not saying I'm not going to support it in the future. But currently
> ipw2100 doesn't support big endian machines is the truth. One reason is
> because I don't have such a box with an ipw2100 card. If you or someone
> has such a platform and is willing to try patches for me, I'm happy to
> get this done. That's why the ipw2200 driver has the BE supported.

I'm happy to test ipw2100 on big endian systems if you send me a card.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-08-22  9:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-21  3:37 [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms Zhu Yi
2006-08-21  9:52 ` Christoph Hellwig
2006-08-22  4:50   ` Zhu Yi
2006-08-22  9:11     ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).