From: Jarek Poplawski <jarkao2@o2.pl>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] locking bug in fib_semantics.c
Date: Mon, 21 Aug 2006 13:02:01 +0200 [thread overview]
Message-ID: <20060821110201.GA3674@ff.dom.local> (raw)
In-Reply-To: <20060821.011703.78716718.davem@davemloft.net>
On 21-08-2006 10:17, David Miller wrote:
> From: Jarek Poplawski <jarkao2@o2.pl>
> Date: Mon, 21 Aug 2006 10:16:43 +0200
...
>> But I hope the real reason for this patch isn't exactly like that.
>> Could fib_release_info() be interrupted by BH really?
>
> Absolutely, yes it can. What makes you think it can't?
>
> All of the call sites I have checked cause it to run with
> BH's enabled, and that allows ip_fib_check_default() to
> potentially run. All we need is one such case to cause
> the deadlock.
>
> I was skeptical of this case too, until I checked how
> fib_release_info() was called.
I overlooked this - so I've to sharpen my sight and look at it
again - now knowing it's there.
Thanks for your response. I didn't expect it so fast and right
from the top!
Jarek P.
next prev parent reply other threads:[~2006-08-21 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 9:36 [PATCH] locking bug in fib_semantics.c Alexey Kuznetsov
2006-08-18 1:29 ` David Miller
2006-08-21 8:16 ` Jarek Poplawski
2006-08-21 8:17 ` David Miller
2006-08-21 11:02 ` Jarek Poplawski [this message]
2006-08-22 10:35 ` Jarek Poplawski
2006-08-23 6:34 ` Jarek Poplawski
2006-08-23 18:31 ` Stephen Hemminger
2006-08-24 11:04 ` Jarek Poplawski
2006-08-24 14:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821110201.GA3674@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).