From: Andrew Morton <akpm@osdl.org>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch] Signedness issue in drivers/net/3c515.c
Date: Mon, 21 Aug 2006 14:05:58 -0700 [thread overview]
Message-ID: <20060821140558.4cfee23c.akpm@osdl.org> (raw)
In-Reply-To: <1156009077.18374.1.camel@alice>
On Sat, 19 Aug 2006 19:37:57 +0200
Eric Sesterhenn <snakebyte@gmx.de> wrote:
> while playing with gcc 4.1 -Wextra warnings, I came across this one:
>
> drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true
>
> Since i is unsigned the >= 0 check in the for loop is always true,
> so we might spin there forever unless the if condition triggers.
> Since i is only used in this loop, this patch changes it to
> an integer.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-rc4/drivers/net/3c515.c.orig 2006-08-19 19:35:04.000000000 +0200
> +++ linux-2.6.18-rc4/drivers/net/3c515.c 2006-08-19 19:35:14.000000000 +0200
> @@ -1003,7 +1003,8 @@ static int corkscrew_start_xmit(struct s
> /* Calculate the next Tx descriptor entry. */
> int entry = vp->cur_tx % TX_RING_SIZE;
> struct boom_tx_desc *prev_entry;
> - unsigned long flags, i;
> + unsigned long flags;
> + int i;
>
> if (vp->tx_full) /* No room to transmit with */
> return 1;
Which affects this loop:
/* Wait for the stall to complete. */
for (i = 20; i >= 0; i--)
if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0)
break;
Your fix will convert this indefinit wait into a bounded one. It might
cause the driver to malfunction.
Given that our pool of 3c515 testers is less than enormous, a more prudent
change might be to remove `i' and simply formalise the existing behaviour
into a while(1) loop.
next parent reply other threads:[~2006-08-21 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1156009077.18374.1.camel@alice>
2006-08-21 21:05 ` Andrew Morton [this message]
2006-08-21 22:13 ` [Patch] Signedness issue in drivers/net/3c515.c Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821140558.4cfee23c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).