From: "Amit S. Kale" <amitkale@linsyssoft.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "Amit S. Kale" <amitkale@netxen.com>,
netdev@vger.kernel.org, jeff@garzik.org, sanjeev@netxen.com,
unmproj@linsyssoft.com, rob@netxen.com
Subject: Re: [PATCH 2.6.17 4/9] NetXen: intr routines and niu handling
Date: Mon, 21 Aug 2006 14:10:34 +0530 [thread overview]
Message-ID: <200608211410.35076.amitkale@linsyssoft.com> (raw)
In-Reply-To: <20060818082206.54f193ff@dxpl.pdx.osdl.net>
On Friday 18 August 2006 20:52, Stephen Hemminger wrote:
>
> Why keep track of statistics in one structure then copy out to net_device
> format? Instead just use original format.
net_device structure contains "unsigned long" fields. netxen_port_stats
contains u64 fields. rx_bytes and tx_bytes can easily overflow for 10G cards.
ethtool_status contains u64 stats; is it a good time to make net_device_stats
64 bit?
-Amit
next prev parent reply other threads:[~2006-08-21 8:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 14:38 [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver Amit S. Kale
2006-08-18 14:44 ` [PATCH 2.6.17 1/9] NetXen: Makefile and driver main file Amit S. Kale
2006-08-18 14:58 ` [PATCH 2.6.17 2/9] NetXen: Hardware access routines Amit S. Kale
2006-08-18 15:16 ` Stephen Hemminger
2006-08-21 8:27 ` Amit S. Kale
2006-08-21 14:03 ` Stephen Hemminger
2006-08-25 18:23 ` Sanjeev Jorapur
2006-08-28 9:52 ` Amit S. Kale
2006-08-21 9:55 ` [PATCH 2.6.17 2/9] NetXen: Hardware access routines (name prefixed) Pradeep Dalvi
2006-08-21 10:01 ` [PATCH 2.6.17 1/9] NetXen: Makefile and driver main file (name prefix change) Pradeep Dalvi
2006-08-18 15:01 ` [PATCH 2.6.17 3/9] NetXen: hw initialization routines Amit S. Kale
2006-08-21 10:04 ` [PATCH 2.6.17 3/9] NetXen: hw initialization routines (name prefix change) Pradeep Dalvi
2006-08-18 15:04 ` [PATCH 2.6.17 4/9] NetXen: intr routines and niu handling Amit S. Kale
2006-08-18 15:22 ` Stephen Hemminger
2006-08-21 8:40 ` Amit S. Kale [this message]
2006-08-18 15:06 ` [PATCH 2.6.17 5/9] NetXen: ethtool interface Amit S. Kale
2006-08-18 15:10 ` [PATCH 2.6.17 6/9] NetXen: Main header file Amit S. Kale
2006-08-21 10:05 ` [PATCH 2.6.17 6/9] NetXen: Main header file (Name prefix change) Pradeep Dalvi
2006-08-18 15:12 ` [PATCH 2.6.17 7/9] NetXen: hw access routines header file Amit S. Kale
2006-08-18 15:14 ` [PATCH 2.6.17 8/9] NetXen: Header file and ioctl " Amit S. Kale
2006-08-18 15:17 ` [PATCH 2.6.17 9/9] NetXen: CRB reg defininitions Amit S. Kale
2006-08-22 7:43 ` [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver Pradeep Dalvi
2006-08-24 0:04 ` Don Fry
2006-08-25 13:19 ` Amit S. Kale
2006-08-24 20:36 ` [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver - patch for big-endian systems wen xiong
2006-08-24 21:29 ` Michael Buesch
2006-08-24 21:40 ` Francois Romieu
2006-08-25 13:18 ` Amit S. Kale
-- strict thread matches above, loose matches on Subject: below --
2006-08-31 14:02 [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver Amit S. Kale
2006-08-31 14:20 ` [PATCH 2.6.17 4/9] NetXen: intr routines and niu handling Amit S. Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608211410.35076.amitkale@linsyssoft.com \
--to=amitkale@linsyssoft.com \
--cc=amitkale@netxen.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rob@netxen.com \
--cc=sanjeev@netxen.com \
--cc=shemminger@osdl.org \
--cc=unmproj@linsyssoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).