From: Greg KH <gregkh@suse.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>,
netdev@vger.kernel.org, Jouni Malinen <jkm@devicescape.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] wireless-dev: relax sysfs permissions
Date: Tue, 22 Aug 2006 15:20:02 -0700 [thread overview]
Message-ID: <20060822222002.GA29875@suse.de> (raw)
In-Reply-To: <20060822164740.51861395@griffin.suse.cz>
On Tue, Aug 22, 2006 at 04:47:40PM +0200, Jiri Benc wrote:
> On Wed, 16 Aug 2006 15:49:45 +0200, Johannes Berg wrote:
> > The sysfs attributes add_iface and remove_iface both check for
> > CAP_NET_ADMIN whenever something is written. Hence, permissions for the
> > files should be relaxed so that someone who is not root but happens to
> > have CAP_NET_ADMIN can do things.
>
> I'm not sure about this. Greg, what's the policy here?
I don't know, it's not a normal sysfs thing to rely on capability
checks, almost everything that I know of uses the permission bits on the
files. But I don't have a problem with making the permissions on the
file open, yet restricting things to CAP_NET_ADMIN, if that preserves
the proper functionality.
thanks,
greg k-h
prev parent reply other threads:[~2006-08-22 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 13:49 [PATCH] wireless-dev: relax sysfs permissions Johannes Berg
2006-08-22 14:47 ` Jiri Benc
2006-08-22 22:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822222002.GA29875@suse.de \
--to=gregkh@suse.de \
--cc=jbenc@suse.cz \
--cc=jkm@devicescape.com \
--cc=johannes@sipsolutions.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).