netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@o2.pl>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] locking bug in fib_semantics.c
Date: Wed, 23 Aug 2006 08:34:06 +0200	[thread overview]
Message-ID: <20060823063406.GA1948@ff.dom.local> (raw)
In-Reply-To: <20060822103556.GA3262@ff.dom.local>

On Tue, Aug 22, 2006 at 12:35:56PM +0200, Jarek Poplawski wrote:
... 
> Hello,
> I've found it at last but on that occasion I've got some
> doubt according to rcu_read_lock and rcu_call treatment:
...

Actually there is one more doubt (bug really, but
not very probable): proc file reading is without any
locking in fib_hash.c, so if somebody uses programs
which do that often, he could have problems while
adding or deleting a route in a wrong time. If it
will be ever changed, fz_nent should also be ++/--
under lock, I think. 

Jarek P.
 
PS: linux-2.6.18-rc4

  reply	other threads:[~2006-08-23  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17  9:36 [PATCH] locking bug in fib_semantics.c Alexey Kuznetsov
2006-08-18  1:29 ` David Miller
2006-08-21  8:16 ` Jarek Poplawski
2006-08-21  8:17   ` David Miller
2006-08-21 11:02     ` Jarek Poplawski
2006-08-22 10:35       ` Jarek Poplawski
2006-08-23  6:34         ` Jarek Poplawski [this message]
2006-08-23 18:31         ` Stephen Hemminger
2006-08-24 11:04           ` Jarek Poplawski
2006-08-24 14:18             ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060823063406.GA1948@ff.dom.local \
    --to=jarkao2@o2.pl \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).