From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [take12 0/3] kevent: Generic event handling mechanism. Date: Wed, 23 Aug 2006 12:39:00 +0400 Message-ID: <20060823083859.GA8936@2ka.mipt.ru> References: <20060822231129.GA18296@ms2.inr.ac.ru> <20060822.173200.126578369.davem@davemloft.net> <20060823065659.GC24787@2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Cc: David Miller , kuznet@ms2.inr.ac.ru, nmiell@comcast.net, linux-kernel@vger.kernel.org, drepper@redhat.com, akpm@osdl.org, netdev@vger.kernel.org, zach.brown@oracle.com, hch@infradead.org Return-path: Received: from relay.2ka.mipt.ru ([194.85.82.65]:24284 "EHLO 2ka.mipt.ru") by vger.kernel.org with ESMTP id S964789AbWHWIpF (ORCPT ); Wed, 23 Aug 2006 04:45:05 -0400 To: Jari Sundell Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Aug 23, 2006 at 10:22:06AM +0200, Jari Sundell (sundell.software@gmail.com) wrote: > On 8/23/06, Evgeniy Polyakov wrote: > >void * in structure exported to userspace is forbidden. > > Only void * I'm seeing belongs to the user, (udata) perhaps you are > talking of something different? Yes, exactly about it. I put union { u32 a[2]; void *b; } epcially to eliminate that problem. And I'm not that sure aboit stuff like uptr_t or how they call pointers in userspace and kernelspace. > >long in syscall requires wrapper in per-arch code (although that > >workaround _is_ there, it does not mean that broken interface should > >be used). > >poll uses millisecods - it is perfectly ok. > > The kernel is there to hide those ugly implementation details from the > user, so I don't care that much about a workaround being required in > some cases. More important, IMHO is consistency with the POSIX system > calls. > > I guess as long as you use usec, at least it won't be a pain to use. Andrew suggested to use nanoseconds there in u64 variable. I think it is ok. > Rakshasa -- Evgeniy Polyakov