[PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence

[PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence

[Larry Finger]

John,

Please apply this to wireless-2.6.

Michael - bcm43xx-d80211 probably needs this as well.

Larry

---------------------------------------------------

When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up 
wrong, which leads to a large number of assert(bcm->mac_suspended>=0) messages. This one-line patch 
fixes this problem.

Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>

index b095f3c..f532f3c 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3484,6 +3484,7 @@ int bcm43xx_select_wireless_core(struct
  	bcm43xx_macfilter_clear(bcm, BCM43xx_MACFILTER_ASSOC);
  	bcm43xx_macfilter_set(bcm, BCM43xx_MACFILTER_SELF, (u8 *)(bcm->net_dev->dev_addr));
  	bcm43xx_security_init(bcm);
+	bcm->mac_suspended = 1;
  	ieee80211softmac_start(bcm->net_dev);

  	/* Let's go! Be careful after enabling the IRQs.

Re: [PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence

[Michael Buesch]

On Wednesday 23 August 2006 00:07, Larry Finger wrote:
> John,
> 
> Please apply this to wireless-2.6.
> 
> Michael - bcm43xx-d80211 probably needs this as well.
> 
> Larry
> 
> ---------------------------------------------------
> 
> When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up 
> wrong, which leads to a large number of assert(bcm->mac_suspended>=0) messages. This one-line patch 
> fixes this problem.

I think the following is the correct fix for the issue.
It is already in the d80211 branch. (Seems like it got lost somehow).
Can you test this?

Signed-off-by: Michael Buesch <mb@bu3sch.de>

Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c	2006-08-23 10:00:27.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c	2006-08-23 10:01:45.000000000 +0200
@@ -3349,6 +3349,8 @@
 	memset(bcm->dma_reason, 0, sizeof(bcm->dma_reason));
 	bcm->irq_savedstate = BCM43xx_IRQ_INITIAL;
 
+	bcm->mac_suspended = 1;
+
 	/* Noise calculation context */
 	memset(&bcm->noisecalc, 0, sizeof(bcm->noisecalc));
 

-- 
Greetings Michael.