From: Michael Buesch <mb@bu3sch.de>
To: Andrew Morton <akpm@osdl.org>
Cc: zambrano@broadcom.com, netdev@vger.kernel.org, davem@redhat.com
Subject: [PATCH] b44: fix eeprom endianess issue
Date: Wed, 23 Aug 2006 12:32:05 +0200 [thread overview]
Message-ID: <200608231232.05750.mb@bu3sch.de> (raw)
Hi Andrew,
Please apply this patch to -mm for testing.
I think in the long term we want to convert b44 to use the
new ssb backend driver, which would also fix the issue, but
for now I think this small fix is best.
Please note that this test is only compile tested, as
I don't have a b44 device.
--
This fixes eeprom read on big-endian architectures.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: linux-2.6/drivers/net/b44.c
===================================================================
--- linux-2.6.orig/drivers/net/b44.c 2006-08-22 11:27:56.000000000 +0200
+++ linux-2.6/drivers/net/b44.c 2006-08-23 12:26:31.000000000 +0200
@@ -2055,7 +2055,7 @@
u16 *ptr = (u16 *) data;
for (i = 0; i < 128; i += 2)
- ptr[i / 2] = readw(bp->regs + 4096 + i);
+ ptr[i / 2] = cpu_to_le16(readw(bp->regs + 4096 + i));
return 0;
}
--
Greetings Michael.
next reply other threads:[~2006-08-23 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 10:32 Michael Buesch [this message]
2006-08-23 10:38 ` [PATCH] b44: fix eeprom endianess issue Michael Buesch
2006-08-23 16:55 ` Jeff Garzik
2006-08-23 18:06 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608231232.05750.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).