From: David Miller <davem@davemloft.net>
To: shemminger@osdl.org
Cc: sithglan@stud.uni-erlangen.de, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPV6 : segmentation offload not set correctly on TCP children
Date: Fri, 25 Aug 2006 15:56:02 -0700 (PDT) [thread overview]
Message-ID: <20060825.155602.132757635.davem@davemloft.net> (raw)
In-Reply-To: <20060825154353.3ecaf508@localhost.localdomain>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 25 Aug 2006 15:43:53 -0700
> TCP over IPV6 would incorrectly inherit the GSO settings.
> This would cause kernel to send Tcp Segmentation Offload packets for
> IPV6 data to devices that can't handle it. It caused the sky2 driver
> to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050
> and the e1000 would generate bogus packets. I can't blame the
> hardware for gagging if the upper layers feed it garbage.
>
> This was a new bug in 2.6.18 introduced with GSO support.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Good catch. Applied, thanks Stephen.
next prev parent reply other threads:[~2006-08-25 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060821212243.GA1558@cip.informatik.uni-erlangen.de>
2006-08-21 22:02 ` sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable) Stephen Hemminger
2006-08-21 22:26 ` Thomas Glanzmann
2006-08-25 22:43 ` [PATCH] IPV6 : segmentation offload not set correctly on TCP children Stephen Hemminger
2006-08-25 22:56 ` David Miller [this message]
2006-08-25 23:06 ` Thomas Glanzmann
2006-08-25 23:24 ` Stephen Hemminger
2006-08-25 23:29 ` Stephen Hemminger
2006-08-25 23:59 ` Herbert Xu
2006-08-21 22:28 ` sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable) Thomas Glanzmann
2006-08-21 22:56 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825.155602.132757635.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=sithglan@stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).