From: Ivo van Doorn <ivdoorn@gmail.com>
To: netdev@vger.kernel.org
Cc: linville@tuxdriver.com
Subject: [PATCH 8/10] rt2x00: change variable name
Date: Sun, 27 Aug 2006 17:39:15 +0200 [thread overview]
Message-ID: <200608271739.15534.IvDoorn@gmail.com> (raw)
When setting the ARCSR registers we could use a better/more descriptive
and already available variable name than plain "value".
Signed-off-by Ivo van Doorn <ivdoorn@gmail.com>
---
diff -rU3 wireless-dev-rt2x00-netif/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-rt2x00-variable/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
--- wireless-dev-rt2x00-netif/drivers/net/wireless/d80211/rt2x00/rt2400pci.c 2006-08-27 16:32:51.000000000 +0200
+++ wireless-dev-rt2x00-variable/drivers/net/wireless/d80211/rt2x00/rt2400pci.c 2006-08-27 16:56:28.000000000 +0200
@@ -773,12 +773,12 @@
rt2x00_set_field32(®[0], TXCSR1_ACK_CONSUME_TIME, value);
rt2x00_register_write(rt2x00dev, TXCSR1, reg[0]);
- value = DEVICE_GET_RATE_FIELD(rate, PREAMBLE) ? 8 : 0;
+ preamble = DEVICE_GET_RATE_FIELD(rate, PREAMBLE) ? 8 : 0;
- reg[0] = cpu_to_le32(0x00700400 | value); /* ARCSR2 */
- reg[1] = cpu_to_le32(0x00380401 | value); /* ARCSR3 */
- reg[2] = cpu_to_le32(0x00150402 | value); /* ARCSR4 */
- reg[3] = cpu_to_le32(0x000b8403 | value); /* ARCSR5 */
+ reg[0] = cpu_to_le32(0x00700400 | preamble); /* ARCSR2 */
+ reg[1] = cpu_to_le32(0x00380401 | preamble); /* ARCSR3 */
+ reg[2] = cpu_to_le32(0x00150402 | preamble); /* ARCSR4 */
+ reg[3] = cpu_to_le32(0x000b8403 | preamble); /* ARCSR5 */
rt2x00_register_multiwrite(rt2x00dev, ARCSR2, ®[0], sizeof(reg));
}
diff -rU3 wireless-dev-rt2x00-netif/drivers/net/wireless/d80211/rt2x00/rt2500pci.c wireless-dev-rt2x00-variable/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
--- wireless-dev-rt2x00-netif/drivers/net/wireless/d80211/rt2x00/rt2500pci.c 2006-08-27 16:34:16.000000000 +0200
+++ wireless-dev-rt2x00-variable/drivers/net/wireless/d80211/rt2x00/rt2500pci.c 2006-08-27 16:56:34.000000000 +0200
@@ -839,12 +839,12 @@
rt2x00_set_field32(®[0], TXCSR1_ACK_CONSUME_TIME, value);
rt2x00_register_write(rt2x00dev, TXCSR1, reg[0]);
- value = DEVICE_GET_RATE_FIELD(rate, PREAMBLE) ? 8 : 0;
+ preamble = DEVICE_GET_RATE_FIELD(rate, PREAMBLE) ? 8 : 0;
- reg[0] = cpu_to_le32(0x00700400 | value); /* ARCSR2 */
- reg[1] = cpu_to_le32(0x00380401 | value); /* ARCSR3 */
- reg[2] = cpu_to_le32(0x00150402 | value); /* ARCSR4 */
- reg[3] = cpu_to_le32(0x000b8403 | value); /* ARCSR5 */
+ reg[0] = cpu_to_le32(0x00700400 | preamble); /* ARCSR2 */
+ reg[1] = cpu_to_le32(0x00380401 | preamble); /* ARCSR3 */
+ reg[2] = cpu_to_le32(0x00150402 | preamble); /* ARCSR4 */
+ reg[3] = cpu_to_le32(0x000b8403 | preamble); /* ARCSR5 */
rt2x00_register_multiwrite(rt2x00dev, ARCSR2, ®[0], sizeof(reg));
}
reply other threads:[~2006-08-27 15:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608271739.15534.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).