Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

["Amit S. Kale" <amitkale@linsyssoft.com>]

On Monday 21 August 2006 19:33, Stephen Hemminger wrote:
> On Mon, 21 Aug 2006 13:57:23 +0530
>
> "Amit S. Kale" <amitkale@linsyssoft.com> wrote:
> > We can certainly create a table for all error messages. It'll hurt
> > readability of code in many of the other places where printks are used to
> > indicate some hardware error.
> > -Amit
>
> My suggestion was intended as an way to handle multiple driver versions
> all using the same firmware or vice versa. By locking the firmware and
> driver version together you might make maintenance more difficult.

Ah, I had missed that completely in your first email. Thanks for your 
suggestion.

The NetXen firmware will most probably keep changing. It's hardware is 
flexible enough, so the firmware changes will possibly be varied in nature. 
Thinking about this further, it seems we should coalesce firmware dependent 
code into a few isolated functions. While this may be difficult, we should do 
it anyway. Hopefully future changes will not cause these efforts to go waste.
-Amit