2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error

2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error

[Adrian Bunk]

On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
>  git-net.patch
>...
>  git trees
>...

<--  snip  -->

...
  CC      net/netfilter/nf_conntrack_ftp.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c: In function ‘get_ipv6_addr’:
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: warning: implicit declaration of function ‘in6_pton’
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: ‘end’ undeclared (first use in this function)
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: for each function it appears in.)
make[3]: *** [net/netfilter/nf_conntrack_ftp.o] Error 1

<--  snip  -->
 
cu
Adrian

-- 

    Gentoo kernels are 42 times more popular than SUSE kernels among
    KLive users  (a service by SUSE contractor Andrea Arcangeli that
    gathers data about kernels from many users worldwide).

       There are three kinds of lies: Lies, Damn Lies, and Statistics.
                                                    Benjamin Disraeli

Re: 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error

[David Miller]

From: Adrian Bunk <bunk@stusta.de>
Date: Sun, 27 Aug 2006 04:42:19 +0200

>   CC      net/netfilter/nf_conntrack_ftp.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c: In function ^[$,1rx^[(Bget_ipv6_addr^[$,1ry^[(B:
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: warning: implicit declaration of function ^[$,1rx^[(Bin6_pton^[$,1ry^[(B
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: ^[$,1rx^[(Bend^[$,1ry^[(B undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: for each function it appears in.)
> make[3]: *** [net/netfilter/nf_conntrack_ftp.o] Error 1

So the one single place where we call this new in6_pton() thing,
it doesn't even compile.

Yoshifuji, what tree are you testing your builds against?  This
is the second build failure introduced by this in6_pton()
changeset.

I'm going to butcher it like this so at least it builds.

commit 32677088bc145cf7d45466e39286f1a8c7bf2d67
Author: David S. Miller <davem@sunset.davemloft.net>
Date:   Sat Aug 26 19:48:49 2006 -0700

    [NETFILTER]: Fix nf_conntrack_ftp.c build.
    
    Noticed by Adrian Bunk.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c
index 9dccb40..0c17a5b 100644
--- a/net/netfilter/nf_conntrack_ftp.c
+++ b/net/netfilter/nf_conntrack_ftp.c
@@ -21,6 +21,7 @@ #include <linux/netfilter.h>
 #include <linux/ip.h>
 #include <linux/ipv6.h>
 #include <linux/ctype.h>
+#include <linux/inet.h>
 #include <net/checksum.h>
 #include <net/tcp.h>
 
@@ -114,7 +115,8 @@ static struct ftp_search {
 static int
 get_ipv6_addr(const char *src, size_t dlen, struct in6_addr *dst, u_int8_t term)
 {
-	int ret = in6_pton(src, min_t(size_t, dlen, 0xffff), dst, term, &end);
+	const char *end;
+	int ret = in6_pton(src, min_t(size_t, dlen, 0xffff), (u8 *)dst, term, &end);
 	if (ret > 0)
 		return (int)(end - src);
 	return 0;

divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

[Mattia Dongili]

On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
[...]
>  git-net.patch

got this one when starting sshd:

[   44.412000] divide error: 0000 [#1]
[   44.412000] 4K_STACKS PREEMPT 
[   44.412000] last sysfs file: /devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
[   44.412000] Modules linked in: nfsd exportfs lockd sunrpc ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack iptable_filter ip_tables x_tables ipv6 jfs aes dm_crypt dm_mod rtc sony_acpi tun psmouse sonypi speedstep_ich speedstep_lib cpufreq_conservative cpufreq_ondemand freq_table cpufreq_powersave sd_mod usb_storage scsi_mod usbhid pcmcia snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_timer intel_agp agpgart i2c_i801 snd soundcore snd_page_alloc yenta_socket rsrc_nonstatic pcmcia_core uhci_hcd usbcore evdev e100 mii pcspkr
[   44.412000] CPU:    0
[   44.412000] EIP:    0060:[<d1516aca>]    Not tainted VLI
[   44.412000] EFLAGS: 00210246   (2.6.18-rc4-mm3-1 #6) 
[   44.412000] EIP is at fib6_rule_match+0x7a/0x150 [ipv6]
[   44.412000] eax: 00000000   ebx: cd9d4e30   ecx: d15290e0   edx: 00000000
[   44.412000] esi: cd7d9e08   edi: cd9d4e30   ebp: cd9d4d34   esp: cd9d4d0c
[   44.412000] ds: 007b   es: 007b   ss: 0068
[   44.412000] Process sshd (pid: 3780, ti=cd9d4000 task=cf131590 task.ti=cd9d4000)
[   44.412000] Stack: 00000003 c018b200 00000000 ced9df60 cd9d4d6c 00000000 ced9df60 d15290e0 
[   44.412000]        cd7d9e08 cd9d4e30 cd9d4d58 c02c198e d15290e0 cd9d4e30 00000000 c123f380 
[   44.412000]        cd9d4e30 cd7d9e08 cd9d4e30 cd9d4d80 d15169dc d15290a0 cd9d4e30 00000000 
[   44.412000] Call Trace:
[   44.412000]  [<c02c198e>] fib_rules_lookup+0x5e/0xe0
[   44.412000]  [<d15169dc>] fib6_rule_lookup+0x3c/0xb0 [ipv6]
[   44.412000]  [<d14f8702>] ip6_route_output+0x32/0x40 [ipv6]
[   44.412000]  [<d14ed155>] ip6_dst_lookup_tail+0x95/0xd0 [ipv6]
[   44.412000]  [<d14ed1a7>] ip6_dst_lookup+0x17/0x20 [ipv6]
[   44.412000]  [<d15120ce>] ip6_datagram_connect+0x36e/0x6c0 [ipv6]
[   44.412000]  [<c02f6829>] inet_dgram_connect+0x39/0x80
[   44.412000]  [<c02a6ceb>] sys_connect+0x6b/0x90
[   44.412000]  [<c02a846f>] sys_socketcall+0x9f/0x260
[   44.412000]  [<c010325b>] syscall_call+0x7/0xb
[   44.412000]  [<b7c7c93c>] 0xb7c7c93c
[   44.412000]  =======================
[   44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89 
[   44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c
[   44.412000]  <6>note: sshd[3780] exited with preempt_count 1

config and full dmesg:
http://oioio.altervista.org/linux/config-2.6.18-rc4-mm3-1
http://oioio.altervista.org/linux/dmesg-2.6.18-rc4-mm3-1

it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
avoid proposing a wrong patch :)

-- 
mattia
:wq!

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

[Andrew Morton]

On Mon, 28 Aug 2006 22:07:16 +0200
Mattia Dongili <malattia@linux.it> wrote:

> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
> [...]
> >  git-net.patch
> 
> got this one when starting sshd:
> 
> [   44.412000] divide error: 0000 [#1]
> [   44.412000] 4K_STACKS PREEMPT 
> [   44.412000] last sysfs file: /devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
> [   44.412000] Modules linked in: nfsd exportfs lockd sunrpc ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack iptable_filter ip_tables x_tables ipv6 jfs aes dm_crypt dm_mod rtc sony_acpi tun psmouse sonypi speedstep_ich speedstep_lib cpufreq_conservative cpufreq_ondemand freq_table cpufreq_powersave sd_mod usb_storage scsi_mod usbhid pcmcia snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_timer intel_agp agpgart i2c_i801 snd soundcore snd_page_alloc yenta_socket rsrc_nonstatic pcmcia_core uhci_hcd usbcore evdev e100 mii pcspkr
> [   44.412000] CPU:    0
> [   44.412000] EIP:    0060:[<d1516aca>]    Not tainted VLI
> [   44.412000] EFLAGS: 00210246   (2.6.18-rc4-mm3-1 #6) 
> [   44.412000] EIP is at fib6_rule_match+0x7a/0x150 [ipv6]
> [   44.412000] eax: 00000000   ebx: cd9d4e30   ecx: d15290e0   edx: 00000000
> [   44.412000] esi: cd7d9e08   edi: cd9d4e30   ebp: cd9d4d34   esp: cd9d4d0c
> [   44.412000] ds: 007b   es: 007b   ss: 0068
> [   44.412000] Process sshd (pid: 3780, ti=cd9d4000 task=cf131590 task.ti=cd9d4000)
> [   44.412000] Stack: 00000003 c018b200 00000000 ced9df60 cd9d4d6c 00000000 ced9df60 d15290e0 
> [   44.412000]        cd7d9e08 cd9d4e30 cd9d4d58 c02c198e d15290e0 cd9d4e30 00000000 c123f380 
> [   44.412000]        cd9d4e30 cd7d9e08 cd9d4e30 cd9d4d80 d15169dc d15290a0 cd9d4e30 00000000 
> [   44.412000] Call Trace:
> [   44.412000]  [<c02c198e>] fib_rules_lookup+0x5e/0xe0
> [   44.412000]  [<d15169dc>] fib6_rule_lookup+0x3c/0xb0 [ipv6]
> [   44.412000]  [<d14f8702>] ip6_route_output+0x32/0x40 [ipv6]
> [   44.412000]  [<d14ed155>] ip6_dst_lookup_tail+0x95/0xd0 [ipv6]
> [   44.412000]  [<d14ed1a7>] ip6_dst_lookup+0x17/0x20 [ipv6]
> [   44.412000]  [<d15120ce>] ip6_datagram_connect+0x36e/0x6c0 [ipv6]
> [   44.412000]  [<c02f6829>] inet_dgram_connect+0x39/0x80
> [   44.412000]  [<c02a6ceb>] sys_connect+0x6b/0x90
> [   44.412000]  [<c02a846f>] sys_socketcall+0x9f/0x260
> [   44.412000]  [<c010325b>] syscall_call+0x7/0xb
> [   44.412000]  [<b7c7c93c>] 0xb7c7c93c
> [   44.412000]  =======================
> [   44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89 
> [   44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c

I cannot work out how the heck you got a divide instruction in
fib6_rule_match().

Can you please do `make net/ipv6/fib6_rules.s', find the code which
implements fib6_rule_match() (line starting with "fib6_rule_match:") and
send that plus the next 200-odd lines?  Or just stick fib6_rules.s on a
server somewhere?  Or mail me fib6_rules.s off-list.

Thanks.

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

[Andi Kleen]

> I cannot work out how the heck you got a divide instruction in
> fib6_rule_match().

This might be another symptom of the broken smp-alternatives patch.
It tended to randomly corrupt some instructions by inserting different
bytes which then crash in interesting ways.

I already sent a fix for that, but it's not in yet.

-Andi

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

[Andrew Morton]

On Mon, 28 Aug 2006 22:07:16 +0200
Mattia Dongili <malattia@linux.it> wrote:

> [   44.412000]  =======================
> [   44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89 
> [   44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c
> [   44.412000]  <6>note: sshd[3780] exited with preempt_count 1
> 
> config and full dmesg:
> http://oioio.altervista.org/linux/config-2.6.18-rc4-mm3-1
> http://oioio.altervista.org/linux/dmesg-2.6.18-rc4-mm3-1
> 
> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
> avoid proposing a wrong patch :)

Oh.  It looks like this has already been fixed:

#ifdef CONFIG_IPV6_ROUTE_FWMARK
        if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
                return 0;
#endif

there's no divide in there now.

Re: divide error: 0000 in fib6_rule_match

[David Miller]

From: Andrew Morton <akpm@osdl.org>
Date: Mon, 28 Aug 2006 14:30:03 -0700

> Oh.  It looks like this has already been fixed:
> 
> #ifdef CONFIG_IPV6_ROUTE_FWMARK
>         if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
>                 return 0;
> #endif
> 
> there's no divide in there now.

That's right there used to be a typo there.

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

[Mattia Dongili]

On Mon, August 28, 2006 11:30 pm, Andrew Morton said:
> On Mon, 28 Aug 2006 22:07:16 +0200
> Mattia Dongili <malattia@linux.it> wrote:
[...]
>> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
>> avoid proposing a wrong patch :)
>
> Oh.  It looks like this has already been fixed:
>
> #ifdef CONFIG_IPV6_ROUTE_FWMARK
>         if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
>                 return 0;
> #endif
>
> there's no divide in there now.

Ok, great, I have a division instead of the bitwise and there in fact.

thanks
-- 
mattia
:wq!

[-mm patch] net/sched/act_simple.c: make struct simp_hash_info static

[Adrian Bunk]

On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
>  git-net.patch
>...
>  git trees
>...

This patch makes the needlessly global struct simp_hash_info static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.18-rc4-mm3/net/sched/act_simple.c.old	2006-08-30 20:54:20.000000000 +0200
+++ linux-2.6.18-rc4-mm3/net/sched/act_simple.c	2006-08-30 20:54:43.000000000 +0200
@@ -28,7 +28,7 @@
 static u32 simp_idx_gen;
 static DEFINE_RWLOCK(simp_lock);
 
-struct tcf_hashinfo simp_hash_info = {
+static struct tcf_hashinfo simp_hash_info = {
 	.htab	=	tcf_simp_ht,
 	.hmask	=	SIMP_TAB_MASK,
 	.lock	=	&simp_lock,

Re: [-mm patch] net/sched/act_simple.c: make struct simp_hash_info static

[David Miller]

From: Adrian Bunk <bunk@stusta.de>
Date: Wed, 30 Aug 2006 22:35:07 +0200

> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm2:
> >...
> >  git-net.patch
> >...
> >  git trees
> >...
> 
> This patch makes the needlessly global struct simp_hash_info static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Applied, thanks Adrian.