From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: NAPI: netif_rx_reschedule() ?? Date: Thu, 31 Aug 2006 14:29:10 -0700 Message-ID: <20060831142910.427f64fa@localhost.localdomain> References: <20060830161219.7878bada@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:39384 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751182AbWHaV3O (ORCPT ); Thu, 31 Aug 2006 17:29:14 -0400 To: Roland Dreier In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 30 Aug 2006 16:39:14 -0700 Roland Dreier wrote: > Roland> makes sense -- especially since the caller probably also > Roland> deducted N from *budget, and netif_rx_reschedule() doesn't > Roland> touch that. > > Actually, why does undoing the change to quota make sense? Presumably > I passed N packets to netif_receive_skb() -- why shouldn't I deduct N > from quota and *budget? > > - R. This was probably a preventive thing to avoid scheduling when quota remaining was zero? -- Stephen Hemminger