* [NET]: Fix typo causing wrong skb to be freed
@ 2006-08-31 21:26 Thomas Graf
2006-08-31 22:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2006-08-31 21:26 UTC (permalink / raw)
To: davem; +Cc: netdev
A typo introduced by myself which leads to freeing the skb
containing the netlink message when it should free the newly
allocated skb for the reply.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Index: net-2.6.19/net/core/rtnetlink.c
===================================================================
--- net-2.6.19.orig/net/core/rtnetlink.c 2006-08-30 13:14:48.000000000 +0200
+++ net-2.6.19/net/core/rtnetlink.c 2006-08-31 23:21:28.000000000 +0200
@@ -596,7 +596,7 @@
err = rtnl_fill_ifinfo(nskb, dev, iw, iw_buf_len, RTM_NEWLINK,
NETLINK_CB(skb).pid, nlh->nlmsg_seq, 0, 0);
if (err <= 0) {
- kfree_skb(skb);
+ kfree_skb(nskb);
goto errout;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [NET]: Fix typo causing wrong skb to be freed
2006-08-31 21:26 [NET]: Fix typo causing wrong skb to be freed Thomas Graf
@ 2006-08-31 22:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-08-31 22:05 UTC (permalink / raw)
To: tgraf; +Cc: netdev
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 31 Aug 2006 23:26:51 +0200
> A typo introduced by myself which leads to freeing the skb
> containing the netlink message when it should free the newly
> allocated skb for the reply.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks Thomas.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-31 22:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-31 21:26 [NET]: Fix typo causing wrong skb to be freed Thomas Graf
2006-08-31 22:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).