From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stefano Brivio <st3@riseup.net>,
netdev@vger.kernel.org,
Broadcom Linux <bcm43xx-dev@lists.berlios.de>
Subject: Re: [RFC] Patch to add board revision to the WLAN chip_id printout
Date: Fri, 1 Sep 2006 21:00:16 +0200 [thread overview]
Message-ID: <200609012100.16638.mb@bu3sch.de> (raw)
In-Reply-To: <44F85187.3010707@lwfinger.net>
On Friday 01 September 2006 17:28, Larry Finger wrote:
> Michael,
>
> This patch includes the board revision in the chip_id printk for the ssb version of bcm43xx-d80211
> and is meant to be applied to wireless-dev. As we have seen, behavior of the chips can be dependent
> on the rev level, thus a need to have it in the log.
Any specific example on this?
I mean, every revision in the chip (and bcm43xx has a _lot_) can
(and does) change behaviour. But I still think we shouldn't print them
all on initialization. ;)
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> +++ wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> @@ -3346,7 +3346,8 @@ static int bcm43xx_attach_board(struct b
> if (err)
> goto err_chipset_detach;
>
> - printk(KERN_INFO PFX "Broadcom %04X WLAN found\n", bcm->ssb.chip_id);
> + printk(KERN_INFO PFX "Broadcom %04X WLAN, Revision %d found\n",
> + bcm->ssb.chip_id, bcm->board_revision);
>
> /* Attach all IO cores to the backplane. */
> coremask = 0;
>
--
Greetings Michael.
prev parent reply other threads:[~2006-09-01 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 15:28 [RFC] Patch to add board revision to the WLAN chip_id printout Larry Finger
2006-09-01 19:00 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609012100.16638.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=netdev@vger.kernel.org \
--cc=st3@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).