From: Stephen Hemminger <shemminger@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: sky2: hw checksum failures
Date: Mon, 4 Sep 2006 20:56:45 -0700 [thread overview]
Message-ID: <20060904205645.6c80f30c@localhost.localdomain> (raw)
In-Reply-To: <1157427758.22705.65.camel@localhost.localdomain>
On Tue, 05 Sep 2006 13:42:38 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
> > Unneeded byte swap was occurring.
> >
> > --- linux-2.6.orig/drivers/net/sky2.c
> > +++ linux-2.6/drivers/net/sky2.c
> > @@ -2001,7 +2001,7 @@ static int sky2_status_intr(struct sky2_
> > case OP_RXCHKS:
> > skb = sky2->rx_ring[sky2->rx_next].skb;
> > skb->ip_summed = CHECKSUM_HW;
> > - skb->csum = le16_to_cpu(status);
> > + skb->csum = status;
> > break;
> >
> > case OP_TXINDEXLE:
>
> I've removed it in my paches (have you seen the other patches I sent for
> this driver ?), though I'm pre-swapping status and lenght now before the
> switch/case so there might still be an issue there. I'll have a look.
The other tack would be to leave the "reverse in hw" flag on and take out all the existing
swap calls but then you have to add an ifdef to re-order all the structures for tx_le, rx_le, status_le.
That is what the vendor (GPL) version of sk98lin does.
next prev parent reply other threads:[~2006-09-05 3:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 0:36 sky2: hw checksum failures Benjamin Herrenschmidt
2006-09-05 3:34 ` Stephen Hemminger
2006-09-05 3:42 ` Benjamin Herrenschmidt
2006-09-05 3:56 ` Stephen Hemminger [this message]
2006-09-05 4:45 ` Benjamin Herrenschmidt
2006-09-05 15:00 ` Stephen Hemminger
2006-09-05 21:12 ` Benjamin Herrenschmidt
2006-09-05 21:31 ` Stephen Hemminger
2006-09-05 21:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904205645.6c80f30c@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).