From: Ben Dooks <ben-linux@fluff.org>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: J?rgen Schindele <linux@schindele.name>, netdev@vger.kernel.org
Subject: Re: [PATCH] DM9000 interrupt is hardware dependant
Date: Mon, 4 Sep 2006 23:40:02 +0100 [thread overview]
Message-ID: <20060904224002.GB3623@home.fluff.org> (raw)
In-Reply-To: <20060904204646.GD3782@xi.wantstofly.org>
On Mon, Sep 04, 2006 at 10:46:46PM +0200, Lennert Buytenhek wrote:
> On Mon, Sep 04, 2006 at 10:17:08PM +0200, J?rgen Schindele wrote:
>
> > i made a patch for an PXA270-evalboard with DM9000
> > ethernet contoller. The Interrupt can be high- or low-
> > active dependant of the wiring of the MDC-(57)pin.
> >
> > Because of this hardware dependency you shoud be able
> > to configure this behaviour in "struct resource dm9000_resources[]"
>
> Putting it in 'struct dm9000_plat_data' sounds like a much better
> idea to me...
>
> Overloading the IRQ number in 'struct resource' is just ugly.
My view is that this would be useful to a number of drivers, and
is a good use of the resource flags for drivers which do not
currently have platform data.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2006-09-04 22:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 20:17 [PATCH] DM9000 interrupt is hardware dependant Jürgen Schindele
2006-09-04 20:46 ` Lennert Buytenhek
2006-09-04 22:40 ` Ben Dooks [this message]
2006-09-04 21:11 ` Francois Romieu
-- strict thread matches above, loose matches on Subject: below --
2006-09-04 21:07 Jürgen Schindele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904224002.GB3623@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=buytenh@wantstofly.org \
--cc=linux@schindele.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).