From: Greg KH <greg@kroah.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Neil Brown <neilb@suse.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>, Nix <nix@esperi.org.uk>,
stable@kernel.org
Subject: Re: [stable] [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming
Date: Wed, 6 Sep 2006 13:47:47 -0700 [thread overview]
Message-ID: <20060906204747.GA18780@kroah.com> (raw)
In-Reply-To: <20060826011839.GA14010@gondor.apana.org.au>
On Sat, Aug 26, 2006 at 11:18:39AM +1000, Herbert Xu wrote:
> On Fri, Aug 25, 2006 at 04:03:16PM -0700, Greg KH wrote:
> >
> > This patch doesn't apply at all to the latest 2.6.17-stable kernel tree.
> > Care to rediff it?
>
> Hmm, I just rebased and it actually applied as is to 2.6.17.11 :)
> Anyway, here is the result:
No, are you sure you are using the right tree?
> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index cff9c3a..d987a27 100644
> --- a/net/ipv4/ip_output.c
> +++ b/net/ipv4/ip_output.c
> @@ -946,7 +946,7 @@ alloc_new_skb:
> skb_prev->csum = csum_sub(skb_prev->csum,
> skb->csum);
> data += fraggap;
> - skb_trim(skb_prev, maxfraglen);
> + pskb_trim_unique(skb_prev, maxfraglen);
> }
Oh wait, this is already in the queue, no wonder it's failing... Sorry
about this, my fault...
greg k-h
prev parent reply other threads:[~2006-09-06 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 21:19 [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming Nix
2006-08-12 22:17 ` Nix
2006-08-13 12:29 ` Nix
2006-08-13 12:59 ` Herbert Xu
2006-08-13 18:24 ` Nix
2006-08-14 3:19 ` David Miller
2006-08-25 23:03 ` Greg KH
2006-08-26 1:18 ` Herbert Xu
2006-09-06 20:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060906204747.GA18780@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).