From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch 37/37] sky2: version 1.6.1 Date: Thu, 7 Sep 2006 14:50:36 -0700 Message-ID: <20060907145036.1f2a7bc4@localhost.localdomain> References: <20060906224631.999046890@quad.kroah.org> <20060906225812.GL15922@kroah.com> <20060907192528.GG8793@ucw.cz> <20060907203426.GB556@suse.de> <20060907210346.GF29890@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, Jeff Garzik , Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, netdev@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:34517 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751851AbWIGVxi (ORCPT ); Thu, 7 Sep 2006 17:53:38 -0400 To: Pavel Machek In-Reply-To: <20060907210346.GF29890@elf.ucw.cz> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 7 Sep 2006 23:03:46 +0200 Pavel Machek wrote: > Hi! > > > > > -stable review patch. If anyone has any objections, please let us know. > > > > > > > > ------------------ > > > > From: Stephen Hemminger > > > > > > > > Since this code incorporates some of the fixes from 2.6.18, change > > > > the version number. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > Not sure, one of 'stable' criteria is 'fixes bad bug'. What bug does > > > this fix? > > > > The previous 5 patches changed this driver, so changing the version > > number of it is acceptable to me. > > Well... I agree that version change is understandable, but it will be > also surprising for the users, and stable rules were quite strict with > "must fix obvious bug"... > I get lots of bug reports which are from distro and other kernels that cherrypick code from stable. How am I supposed to know if it is a new or old problem?