From: Valerie Henson <val_henson@linux.intel.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Grant Grundler <grundler@parisc-linux.org>,
Kyle McMartin <kyle@parisc-linux.org>,
Valerie Henson <val_henson@linux.intel.com>,
Jeff Garzik <jeff@garzik.org>
Subject: [patch 04/10] [TULIP] Flush MMIO writes in reset sequence
Date: Fri, 08 Sep 2006 11:15:37 -0700 [thread overview]
Message-ID: <20060908182023.330738000@linux.intel.com> (raw)
In-Reply-To: 20060908181533.771856000@linux.intel.com
[-- Attachment #1: tulip-flush-mmio-writes-in-reset-sequence --]
[-- Type: text/plain, Size: 1085 bytes --]
From: Grant Grundler <grundler@parisc-linux.org>
The obvious safe registers to read is one from PCI config space.
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
Signed-off-by: Valerie Henson <val_henson@linux.intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
drivers/net/tulip/tulip_core.c | 2 ++
1 files changed, 2 insertions(+)
--- linux-2.6.18-rc4-mm1.orig/drivers/net/tulip/tulip_core.c
+++ linux-2.6.18-rc4-mm1/drivers/net/tulip/tulip_core.c
@@ -295,12 +295,14 @@ static void tulip_up(struct net_device *
/* Reset the chip, holding bit 0 set at least 50 PCI cycles. */
iowrite32(0x00000001, ioaddr + CSR0);
+ pci_read_config_dword(tp->pdev, PCI_COMMAND, &i); /* flush write */
udelay(100);
/* Deassert reset.
Wait the specified 50 PCI cycles after a reset by initializing
Tx and Rx queues and the address filter list. */
iowrite32(tp->csr0, ioaddr + CSR0);
+ pci_read_config_dword(tp->pdev, PCI_COMMAND, &i); /* flush write */
udelay(100);
if (tulip_debug > 1)
--
next prev parent reply other threads:[~2006-09-08 18:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 18:15 [patch 00/10] [TULIP] Tulip update Valerie Henson
2006-09-08 18:15 ` [patch 01/10] [TULIP] Change tulip maintainer Valerie Henson
2006-09-11 13:06 ` Jeff Garzik
2006-09-08 18:15 ` [patch 02/10] [TULIP] Print physical address in tulip_init_one Valerie Henson
2006-09-08 18:15 ` [patch 03/10] [TULIP] Make DS21143 printout match lspci output Valerie Henson
2006-09-08 18:15 ` Valerie Henson [this message]
2006-09-08 18:15 ` [patch 05/10] [TULIP] Defer tulip_select_media() to process context Valerie Henson
2006-09-08 18:15 ` [patch 06/10] [TULIP] Clean up tulip.h Valerie Henson
2006-09-08 18:15 ` [patch 07/10] [TULIP] Use tulip.h in winbond-840.c Valerie Henson
2006-09-08 18:15 ` [patch 08/10] [TULIP] Handle pci_enable_device() errors in resume Valerie Henson
2006-09-08 18:15 ` [patch 09/10] [TULIP] Update tulip version Valerie Henson
2006-09-08 18:15 ` [patch 10/10] [TULIP] Update winbond840.c version Valerie Henson
-- strict thread matches above, loose matches on Subject: below --
2006-08-26 0:02 [patch 00/10] [TULIP] Tulip update Valerie Henson
2006-08-26 0:02 ` [patch 04/10] [TULIP] Flush MMIO writes in reset sequence Valerie Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060908182023.330738000@linux.intel.com \
--to=val_henson@linux.intel.com \
--cc=grundler@parisc-linux.org \
--cc=jeff@garzik.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).