From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
Stefano Brivio <st3@riseup.net>
Subject: Re: [PATCH] bcm43xx-softmac: update noise handling
Date: Tue, 12 Sep 2006 14:21:55 -0400 [thread overview]
Message-ID: <20060912182150.GE7703@tuxdriver.com> (raw)
In-Reply-To: <4506F110.mailATA11P27W@lwfinger.net>
On Tue, Sep 12, 2006 at 12:40:32PM -0500, Larry Finger wrote:
> John,
>
> Please apply this patch to wireless-2.6. In addition, please let me
> know if you have any problems applying it. I'm sending this by a new
> method.
Larry,
That one worked great! One last request: please put any "chit-chat"
or other text not appropriate for the permanent changelog _AFTER_ the
"---" line. Otherwise, I have to edit it out by hand. I reformatted
the text from this patch below as an example of what I mean.
Thanks!
John
======================================================================================
In bcm43xx-softmac, the bcm43xx_stats struct contains a variable that
is no longer used. In addition, two TODO entries related to noise
processing in bcm43xx_rx have been completed, and as unused one
is removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
Please apply this patch to wireless-2.6. In addition, please let me
know if you have any problems applying it. I'm sending this by a new
method.
Larry
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx.h
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx.h
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx.h
@@ -666,7 +666,6 @@ struct bcm43xx_noise_calculation {
};
struct bcm43xx_stats {
- u8 link_quality;
u8 noise;
struct iw_statistics wstats;
/* Store the last TX/RX times here for updating the leds. */
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2006-09-12 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 17:40 [PATCH] bcm43xx-softmac: update noise handling Larry Finger
2006-09-12 18:21 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060912182150.GE7703@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=st3@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).