From: "Dale Farnsworth" <dale@farnsworth.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, Manish Lachwani <mlachwani@mvista.com>
Subject: mv643xx_eth: Unmap DMA buffers in receive path
Date: Tue, 12 Sep 2006 11:22:34 -0700 [thread overview]
Message-ID: <20060912182229.GA11522@xyzzy.farnsworth.org> (raw)
From: Dale Farnsworth <dale@farnsworth.org>
Fix a missing call to dma_unmap_single() in the receive path. Without
this call, errors have been observed on non-cache-coherent systems.
Signed-off-by Dale Farnsworth <dale@farnsworth.org>
---
drivers/net/mv643xx_eth.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.10/drivers/net/mv643xx_eth.c
===================================================================
--- linux-2.6.10.orig/drivers/net/mv643xx_eth.c
+++ linux-2.6.10/drivers/net/mv643xx_eth.c
@@ -402,6 +402,8 @@ static int mv643xx_eth_receive_queue(str
#else
while (eth_port_receive(mp, &pkt_info) == ETH_OK) {
#endif
+ dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE,
+ DMA_FROM_DEVICE);
mp->rx_desc_count--;
received_packets++;
next reply other threads:[~2006-09-12 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 18:22 Dale Farnsworth [this message]
2006-09-13 2:05 ` mv643xx_eth: Unmap DMA buffers in receive path Jeff Garzik
2006-09-13 16:21 ` PATCH " Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060912182229.GA11522@xyzzy.farnsworth.org \
--to=dale@farnsworth.org \
--cc=jgarzik@pobox.com \
--cc=mlachwani@mvista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).