From: Bob Heise <heise2k@gmail.com>
To: Larry.Finger@lwfinger.net, netdev@vger.kernel.org
Subject: netdev tx timeout
Date: Tue, 12 Sep 2006 23:06:15 -0400 [thread overview]
Message-ID: <200609122306.15664.heise2k@gmail.com> (raw)
> Michael,
>
> I still have not gotten a network guru to answer any questions about
> synchronize_net, but I have been testing the patch below:
>
> Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -3169,8 +3169,8 @@ static void bcm43xx_periodic_work_handle
> * be preemtible.
> */
> mutex_lock(&bcm->mutex);
> - netif_stop_queue(bcm->net_dev);
> synchronize_net();
> + netif_stop_queue(bcm->net_dev);
> spin_lock_irqsave(&bcm->irq_lock, flags);
> bcm43xx_mac_suspend(bcm);
> if (bcm43xx_using_pio(bcm))
>
> With the synchronize_net call before the netif_stop_queue as shown, my
> device has run since last Saturday with no netdev watchdog tx timeouts.
> Roughly two days of that testing was done at the accelerated rate of 60X
> normal.
>
> I still hope to get access to a guru, but if that doesn't happen soon, I'm
> going to push this change so that it gets into 2.6.19.
>
> Larry
Larry,
I am running a bcm4306, and got hit by this netdev tx timeout problem. I have
upgraded to the latest wireless-2.6 git and wanted to test out the above
patch. What was the 60x normal testing tweak you made?
Thanks,
Bob Heise
reply other threads:[~2006-09-13 3:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609122306.15664.heise2k@gmail.com \
--to=heise2k@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).