netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Patrick McHardy <kaber@trash.net>
Cc: bert hubert <bert.hubert@netherlabs.nl>,
	cpw@lanl.gov, netdev@vger.kernel.org
Subject: Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp
Date: Thu, 14 Sep 2006 14:52:31 +0400	[thread overview]
Message-ID: <20060914105231.GA24143@ms2.inr.ac.ru> (raw)
In-Reply-To: <450928B2.4090003@trash.net>

Hello!

> [PACKET]: Don't truncate non-linear skbs with mmaped IO
> 
> Non-linear skbs are truncated to their linear part with mmaped IO.
> Fix by using skb_copy_bits instead of memcpy.

Ack.

I remember this trick. The "idea" was that I needed only TCP header in any
case and it was perfect cutoff. This hack was not supposed to survive. :-)

Alexey

  reply	other threads:[~2006-09-14 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-13 11:23 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp bert hubert
2006-09-13 18:44 ` Patrick McHardy
2006-09-14  8:56   ` bert hubert
2006-09-14 10:02     ` Patrick McHardy
2006-09-14 10:52       ` Alexey Kuznetsov [this message]
2006-09-15 12:02       ` bert hubert
2006-09-15 20:16         ` Patrick McHardy
2006-09-18  7:00           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060914105231.GA24143@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=bert.hubert@netherlabs.nl \
    --cc=cpw@lanl.gov \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).