From: Stephen Hemminger <shemminger@osdl.org>
To: Jon Mason <jdmason@kudzu.us>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: add ETH_HLEN to packet_length
Date: Fri, 15 Sep 2006 09:57:19 +0900 [thread overview]
Message-ID: <20060915095719.71baaf91@localhost.localdomain> (raw)
In-Reply-To: <20060914182751.GA15203@kudzu.us>
On Thu, 14 Sep 2006 13:27:54 -0500
Jon Mason <jdmason@kudzu.us> wrote:
> In br_dev_queue_push_xmit, why is the check to drop mtu oversized
> packets not checking for enough room for the impending ETH_HLEN size
> skb_push? In some code currently under development, we are seeing
> skb_under_panic being called from the "skb_push(skb, ETH_HLEN)" in that
> code. It seems to me it would be better to drop those skbs than panic.
> Attached is a patch to do this.
>
> Thanks,
> Jon
This is bridge code, it assumes that any device that claims to be a
ethernet device has done the proper reservation. What device are
you using?
prev parent reply other threads:[~2006-09-15 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 18:27 [PATCH] bridge: add ETH_HLEN to packet_length Jon Mason
2006-09-14 20:53 ` Mika Penttilä
2006-09-15 0:31 ` Jon Mason
2006-09-15 0:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060915095719.71baaf91@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jdmason@kudzu.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).