From: bert hubert <bert.hubert@netherlabs.nl>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, netdev@vger.kernel.org
Subject: Re: tcp congestion policy selection link order fragile
Date: Mon, 18 Sep 2006 11:59:36 +0200 [thread overview]
Message-ID: <20060918095936.GA6161@outpost.ds9a.nl> (raw)
In-Reply-To: <20060918.015130.34760190.davem@davemloft.net>
On Mon, Sep 18, 2006 at 01:51:30AM -0700, David Miller wrote:
> We created TCP_CONG_ADVANCED for a purpose. If you turn that
> thing on, you get full control but if something breaks you get
> to keep the pieces.
But we should not try to break stuff on purpose, no matter how advanced. It
makes zero sense. To reiterate, when compiling in multiple TCP policies, a
*random* one gets enabled. This is not something we want to offer even
advanced users. It is a kernel, not an adventure course.
Please consider this near-oneliner patch which makes stuff behave more like
people expect: loading a module, or compiling in a congestion avoidance
policy only makes it available, but does not turn it on by default.
It also cleans up two notices a bit.
I've tested this patch and it does the job for me, reno is now the default,
even when more advanced options are compiled in, but the rest is still
available.
When in doubt, consider that I discovered this because my kernel was
crashing, and that this is bound to generate heaps of annoying email
otherwise.
Thanks.
Signed-off-by: bert hubert <bert.hubert@netherlabs.nl>
--- linux-2.6.18-rc7/net/ipv4/tcp_cong.c.org 2006-09-18 11:42:25.000000000 +0200
+++ linux-2.6.18-rc7/net/ipv4/tcp_cong.c 2006-09-18 11:43:45.000000000 +0200
@@ -45,11 +45,11 @@
spin_lock(&tcp_cong_list_lock);
if (tcp_ca_find(ca->name)) {
- printk(KERN_NOTICE "TCP %s already registered\n", ca->name);
+ printk(KERN_NOTICE "TCP congestion control '%s' already registered\n", ca->name);
ret = -EEXIST;
} else {
- list_add_rcu(&ca->list, &tcp_cong_list);
- printk(KERN_INFO "TCP %s registered\n", ca->name);
+ list_add_tail_rcu(&ca->list, &tcp_cong_list);
+ printk(KERN_INFO "TCP congestion control '%s' registered\n", ca->name);
}
spin_unlock(&tcp_cong_list_lock);
--
http://www.PowerDNS.com Open source, database driven DNS Software
http://netherlabs.nl Open and Closed source services
next prev parent reply other threads:[~2006-09-18 9:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-16 22:19 2.6.18-rc[67] crashes in TCP ack handling bert hubert
2006-09-16 23:32 ` Stephen Hemminger
2006-09-17 10:11 ` bert hubert
2006-09-17 11:53 ` Stephen Hemminger
[not found] ` <20060917122153.GA2932@outpost.ds9a.nl>
2006-09-17 13:11 ` tcp congestion policy selection link order fragile Stephen Hemminger
2006-09-17 14:51 ` bert hubert
2006-09-18 23:41 ` Stephen Hemminger
2006-09-18 8:51 ` David Miller
2006-09-18 9:59 ` bert hubert [this message]
2006-09-18 14:06 ` David Miller
2006-09-18 15:40 ` bert hubert
2006-09-18 18:53 ` David Miller
2006-09-18 19:52 ` bert hubert
2006-09-19 4:41 ` [PATCH] tcp: set congestion default through Kconfig Stephen Hemminger
2006-09-19 5:08 ` Ian McDonald
2006-09-19 10:03 ` Andi Kleen
2006-09-19 12:35 ` Hagen Paul Pfeifer
2006-09-19 16:10 ` David Miller
2006-09-19 17:28 ` Stephen Hemminger
2006-09-19 15:29 ` Stephen Hemminger
2006-09-19 19:29 ` David Miller
2006-09-19 19:30 ` David Miller
2006-09-19 19:33 ` David Miller
2006-09-19 19:39 ` Stephen Hemminger
2006-09-19 20:41 ` [PATCH] tcp: set congestion default through Kconfig (v2) Stephen Hemminger
2006-09-19 21:20 ` David Miller
2006-09-19 21:32 ` [PATCH] tcp: simpler bic default Stephen Hemminger
2006-09-19 21:43 ` bert hubert
2006-09-19 22:44 ` David Miller
2006-09-19 23:02 ` Stephen Hemminger
2006-09-19 23:04 ` David Miller
2006-09-19 23:23 ` Stephen Hemminger
2006-09-20 8:17 ` bert hubert
2006-09-20 20:28 ` [PATCH] tcp: default congestion control menu Stephen Hemminger
2006-09-25 3:12 ` David Miller
2006-09-20 20:32 ` [PATCH] tcp: make cubic the default Stephen Hemminger
2006-09-23 11:14 ` tested: " bert hubert
2006-09-23 20:00 ` David Miller
2006-09-25 3:13 ` David Miller
2006-09-19 21:38 ` [PATCH] tcp: set congestion default through Kconfig (v2) bert hubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918095936.GA6161@outpost.ds9a.nl \
--to=bert.hubert@netherlabs.nl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).