From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] tcp: simpler bic default Date: Tue, 19 Sep 2006 16:23:55 -0700 Message-ID: <20060919162355.3a22fec1@localhost.localdomain> References: <20060919214304.GB13543@outpost.ds9a.nl> <20060919.154435.102044066.davem@davemloft.net> <20060919160202.23390471@localhost.localdomain> <20060919.160441.66322371.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: bert.hubert@netherlabs.nl, netdev@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:22234 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750700AbWISXYH (ORCPT ); Tue, 19 Sep 2006 19:24:07 -0400 To: David Miller In-Reply-To: <20060919.160441.66322371.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 19 Sep 2006 16:04:41 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 19 Sep 2006 16:02:02 -0700 > > > > > > When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set > > > and be the default, but that's not what the new code is doing. > > > > > > I'm reverting Stephen's patch (again) until this is all sorted > > > out as things are still broken in various ways even with the > > > followon patch. > > > > I don't see what's wrong, this is on a kernel with the two patches: > > Look more closely: > > > After "make defconfig" > > # CONFIG_TCP_CONG_ADVANCED is not set > > CONFIG_DEFAULT_TCP_CONG="bic" > > # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set > > # CONFIG_IP_NF_TARGET_TCPMSS is not set > > # CONFIG_ISCSI_TCP is not set > > But TCP_CONG_BIC isn't enabled so it won't get built nor be > the default algorithm. When CONG_ADVANCED is off, as it is here, > TCP_CONG_BIC should be "y". That's what happens before your > changes. Okay, build testing all the possibilities now, answer by morning.. -- Stephen Hemminger