From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures. Date: Tue, 19 Sep 2006 17:33:36 -0400 Message-ID: <20060919213336.GA29362@redhat.com> References: <20060919172623.4605.56860.stgit@gitlost.site> <20060919172838.4605.35958.stgit@gitlost.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Garzik, Jeff" , netdev@vger.kernel.org, "Brandeburg, Jesse" , "Kok, Auke" , "Ronciak, John" Return-path: Received: from mx1.redhat.com ([66.187.233.31]:18588 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750891AbWISVd5 (ORCPT ); Tue, 19 Sep 2006 17:33:57 -0400 To: "Kok, Auke" Content-Disposition: inline In-Reply-To: <20060919172838.4605.35958.stgit@gitlost.site> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: > > Refine cb cleaning debug printout and print out all cleaned cbs' status. Add > debug flag for EEPROM csum failures that were overridden by the user. > > Signed-off-by: Jesse Brandeburg > Signed-off-by: Auke Kok > --- > > drivers/net/e100.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/e100.c b/drivers/net/e100.c > index ab0868c..ae93c62 100644 > --- a/drivers/net/e100.c > +++ b/drivers/net/e100.c > @@ -761,6 +761,8 @@ static int e100_eeprom_load(struct nic * > DPRINTK(PROBE, ERR, "EEPROM corrupted\n"); > if (!eeprom_bad_csum_allow) > return -EAGAIN; > + else > + add_taint(TAINT_MACHINE_CHECK); I object to this flag being abused this way. A corrupt EEPROM on a network card has _nothing_ to do with a CPU machine check exception. Dave