From: Jiri Benc <jbenc@suse.cz>
To: Hong Liu <hong.liu@intel.com>
Cc: netdev@vger.kernel.org, "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH]d80211: fix "iwconfig key [x]" behavior
Date: Thu, 21 Sep 2006 17:51:04 +0200 [thread overview]
Message-ID: <20060921175104.31429d65@logostar.upir.cz> (raw)
In-Reply-To: <1157081877.11040.44.camel@devlinux-hong>
Hi,
sorry for the delay.
On Fri, 01 Sep 2006 11:37:57 +0800, Hong Liu wrote:
> @@ -2925,7 +2932,8 @@ static int ieee80211_ioctl_giwencode(str
> return 0;
> }
>
> - erq->length = 0;
> + erq->length = min((int)erq->length, sdata->keys[idx]->keylen);
> + memcpy(key, sdata->keys[idx]->key, erq->length);
> erq->flags |= IW_ENCODE_ENABLED;
>
> return 0;
This is still not correct, erq->length should be set to the actual key
length to allow WE to return -E2BIG in case of too small buffer.
memcpy(key, sdata->keys[idx]->key,
min((int)erq->length, sdata->keys[idx]->keylen));
erq->length = sdata->keys[idx]->keylen;
Jiri
--
Jiri Benc
SUSE Labs
next prev parent reply other threads:[~2006-09-21 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 8:36 [PATCH]d80211: fix "iwconfig key [x]" behavior Hong Liu
2006-08-30 17:24 ` Jiri Benc
2006-09-01 3:37 ` Hong Liu
2006-09-21 15:51 ` Jiri Benc [this message]
2006-09-22 7:56 ` Hong Liu
2006-09-22 12:00 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060921175104.31429d65@logostar.upir.cz \
--to=jbenc@suse.cz \
--cc=hong.liu@intel.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).