From: David Miller <davem@davemloft.net>
To: shemminger@osdl.org
Cc: netdev@vger.kernel.org
Subject: Re: IP fragmentation bug from NFS
Date: Fri, 22 Sep 2006 13:50:54 -0700 (PDT) [thread overview]
Message-ID: <20060922.135054.09947776.davem@davemloft.net> (raw)
In-Reply-To: <20060922133512.01a9e9d0@localhost.localdomain>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 22 Sep 2006 13:35:12 -0700
> http://bugzilla.kernel.org/show_bug.cgi?id=7018
>
> Looking at this, it seems that when NFS hands UDP a fragmented
> (non-linear skb), it traps because it tries to trim bytes off a
> non-linear skb. Not sure if skb_trim needs fixing, or IP is broken..
Should be fixed by: e9fa4f7bd291c29a785666e2fa5a9cf3241ee6c3
[INET]: Use pskb_trim_unique when trimming paged unique skbs
The IPv4/IPv6 datagram output path was using skb_trim to trim paged
packets because they know that the packet has not been cloned yet
(since the packet hasn't been given to anything else in the system).
This broke because skb_trim no longer allows paged packets to be
trimmed. Paged packets must be given to one of the pskb_trim functions
instead.
This patch adds a new pskb_trim_unique function to cover the IPv4/IPv6
datagram output path scenario and replaces the corresponding skb_trim
calls with it.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2006-09-22 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 20:35 IP fragmentation bug from NFS Stephen Hemminger
2006-09-22 20:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060922.135054.09947776.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).