Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

[Andrew Morton]

Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
CONFIG_BRIDGE_NETFILTER.  Because brnf_deferred_hooks is defined in
net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c.

Or something else ;)



Begin forwarded message:

Date: Thu, 21 Sep 2006 14:41:13 -0700
From: bugme-daemon@bugzilla.kernel.org
To: bugme-new@lists.osdl.org
Subject: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c


http://bugzilla.kernel.org/show_bug.cgi?id=7179

           Summary: Compilation of .tmp_linux1 fails due to missing
                    declaration in net/netfilter/xt_physdev.c
    Kernel Version: 2.6.18
            Status: NEW
          Severity: high
             Owner: laforge@gnumonks.org
         Submitter: gfrank@neoservers.com


Most recent kernel where this bug did not occur: 2.6.17.13
Distribution: CentOS
Hardware Environment: Dual Intel Xeon 5160
Software Environment: gcc 3.4.6, glibc 2.3.4, make 3.8
Problem Description:

Using the same config from 2.6.17.13, kernel 2.6.18 fails on make when 
attempting to make .tmp_vmlinux1

LD      .tmp_vmlinux1
net/built-in.o(.text.checkentry+0x1e1): In function `checkentry':
net/netfilter/xt_physdev.c:130: undefined reference to `brnf_deferred_hooks'
make: *** [.tmp_vmlinux1] Error 1

Line 130 is simply "brnf_deferred_hooks = 1;"  This variable is also used on 
line 118.

Adding 

"int brnf_deferred_hooks = 0;" 

in a line before line 104 (static int) will cause .tmp_vmlinux1 to be 
successfully created, and make will finish successfully.  However, it will 
generate a warning (seen below) on now line 119 which can be fixed by changing 
it to: 

"if ((brnf_deferred_hooks == 0) & (info->bitmask & XT_PHYSDEV_OP_OUT) && "

The warning generated is:

net/netfilter/xt_physdev.c: In function `checkentry':
net/netfilter/xt_physdev.c:118: warning: ISO C90 forbids mixed declarations 
and code

The kernel produced after making these changes works fine

Steps to reproduce:

I am unsure of which kernel .config parameter is sparking this.  My .config 
can be found here: http://www.animeforum.com/jakiao/misato.config

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Re: Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

[Jarek Poplawski]

Sorry linux-kernel - it should go to netdev.


On 22-09-2006 10:03, Jarek Poplawski wrote:
> On 22-09-2006 00:37, Andrew Morton wrote:
>> Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
>> CONFIG_BRIDGE_NETFILTER.  Because brnf_deferred_hooks is defined in
>> net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c.
>>
>> Or something else ;)
> 
> From net/netfilter/Kconfig:
> 
> config NETFILTER_XT_MATCH_PHYSDEV
>         tristate '"physdev" match support'
>         depends on NETFILTER_XTABLES && BRIDGE_NETFILTER
> 
> so "properly" generated .config should be enough.
> 
> Jarek P.
> 
> PS: I've just checked and it compiles OK. 

Re: Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

[Jarek Poplawski]

On 22-09-2006 00:37, Andrew Morton wrote:
> Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
> CONFIG_BRIDGE_NETFILTER.  Because brnf_deferred_hooks is defined in
> net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c.
> 
> Or something else ;)
...
> I am unsure of which kernel .config parameter is sparking this.  My .config 
> can be found here: http://www.animeforum.com/jakiao/misato.config

I don't see CONFIG_BRIDGE set in this misato.config,
so CONFIG_BRIDGE_NETFILTER was set in some unofficial way.

Jarek P. 

Re: Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

[Jarek Poplawski]

On Fri, Sep 22, 2006 at 10:41:08AM +0200, Jarek Poplawski wrote:
> On 22-09-2006 00:37, Andrew Morton wrote:
> > Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
> > CONFIG_BRIDGE_NETFILTER.  Because brnf_deferred_hooks is defined in
> > net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c.
> > 
> > Or something else ;)
> ...
> > I am unsure of which kernel .config parameter is sparking this.  My .config 
> > can be found here: http://www.animeforum.com/jakiao/misato.config
> 
> I don't see CONFIG_BRIDGE set in this misato.config,
> so CONFIG_BRIDGE_NETFILTER was set in some unofficial way.

... or I'm blind! Sorry.

There is CONFIG_BRIDGE=m and this is the source of a problem:
config shouldn't allow for:

CONFIG_NETFILTER_BRIDGE=y 
CONFIG_NETFILTER_XT_MATCH_PHYSDEV=y 

Jarek P.