From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH] [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c Date: Fri, 22 Sep 2006 13:48:44 +0200 Message-ID: <20060922114844.GB12425@ff.dom.local> References: <20060921153701.2c49e331.akpm@osdl.org> <20060922084108.GB6820@ff.dom.local> <20060922092731.GC6820@ff.dom.local> <20060922095556.GA11991@ff.dom.local> <4513B7CF.5040209@trash.net> <20060922105122.GA12425@ff.dom.local> <4513C0F2.1030107@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , netdev@vger.kernel.org, "David S\. Miller" Return-path: Received: from mx10.go2.pl ([193.17.41.74]:4242 "EHLO poczta.o2.pl") by vger.kernel.org with ESMTP id S932304AbWIVLoi (ORCPT ); Fri, 22 Sep 2006 07:44:38 -0400 To: Patrick McHardy Content-Disposition: inline In-Reply-To: <4513C0F2.1030107@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Sep 22, 2006 at 12:54:42PM +0200, Patrick McHardy wrote: > Jarek Poplawski wrote: > > On Fri, Sep 22, 2006 at 12:15:43PM +0200, Patrick McHardy wrote: > > ... > > > >>We should fix the physdev dependencies since this is what is causing > >>problems. > > > > ... > > > >> config NETFILTER_XT_MATCH_PHYSDEV > >> tristate '"physdev" match support' > >>- depends on NETFILTER_XTABLES && BRIDGE_NETFILTER > >>+ depends on NETFILTER_XTABLES && BRIDGE && BRIDGE_NETFILTER > > > > > > Sure! But someone may ask what for BRIDGE_NETFILTER depends > > on BRIDGE if you should repeat this? > > Simply because it really depends on BRIDGE. The reason why we need > BRIDGE as dependency here also is because BRIDGE_NETFILTER is a > boolean, but may still result in a module because of special > logic in the bridge makefile. Anyway this special logic is also something misleading: a) BRIDGE_NETFILTER=y and BRIDGE_NETFILTER depends on BRIDGE sugest something which depends on BRIDGE is compiled into kernel, which is usually impossible if BRIDGE=m b) let's assume a) is right; shouldn't this dependency be automatically added to _PHYSDEV etc.? I mean config script behavior - not bridge makefile. Thanks for explanation - my best regards, Jarek P.