From: David Miller <davem@davemloft.net>
To: roland@digitalvampire.org
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
chas@cmf.nrl.navy.mil
Subject: Re: [PATCH] [ATM] he: Fix __init/__devinit conflict
Date: Sun, 24 Sep 2006 20:11:18 -0700 (PDT) [thread overview]
Message-ID: <20060924.201118.71090751.davem@davemloft.net> (raw)
In-Reply-To: <87fyeit8wd.fsf@digitalvampire.org>
From: Roland Dreier <roland@digitalvampire.org>
Date: Sat, 23 Sep 2006 17:17:54 -0700
> Dave, this was acked by Chas (and he even requested it go into 2.6.18)
> but it seems to have gotten dropped somewhere -- it's not in Linus's
> tree even after he pulled your net tree.
>
> Please apply.
Applied.
I was waiting for a resolution in the fact that the copy
Chas posted only had one of the transformations whereas
as you pointed out all of the ones in your original
patch were necessary.
Chas, as a subsystem maintainer, if you change a submitter's patch in
a significant and non-trivial way, you should at least mention a brief
reason why you did that. In this case, why did you delete all of
Roland's __init/__devinit transformations except one when they all
were necessary to fix this bug?
next prev parent reply other threads:[~2006-09-25 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 19:14 [PATCH] [ATM] he: Fix __init/__devinit conflict Roland Dreier
2006-09-24 0:17 ` Roland Dreier
2006-09-25 3:11 ` David Miller [this message]
2006-09-25 3:37 ` Roland Dreier
2006-09-25 9:56 ` chas williams - CONTRACTOR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060924.201118.71090751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=roland@digitalvampire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).