From: Thomas Graf <tgraf@suug.ch>
To: paul.moore@hp.com
Cc: selinux@tycho.nsa.gov, netdev@vger.kernel.org,
sds@epoch.ncsc.mil, jmorris@redhat.com
Subject: Re: [PATCH 4/6] NetLabel: rework the Netlink attribute handling (part 1)
Date: Mon, 25 Sep 2006 11:12:35 +0200 [thread overview]
Message-ID: <20060925091235.GN18349@postel.suug.ch> (raw)
In-Reply-To: <20060921170337.004669000@hp.com>
* paul.moore@hp.com <paul.moore@hp.com> 2006-09-21 12:57
> -int netlbl_netlink_snd_multicast(struct sk_buff *skb, u32 pid, u32 group)
> +int netlbl_netlink_snd_multicast(struct sk_buff *skb,
> + void *buf,
> + u32 pid,
> + u32 group)
> {
> + genlmsg_end(skb, buf);
> return genlmsg_multicast(skb, pid, group, GFP_KERNEL);
> }
This is a bit weird at first, one would expect that the message
is terminated when it is build but I guess this is ok for now.
Rest seems fine.
next prev parent reply other threads:[~2006-09-25 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 16:57 [PATCH 0/6] NetLabel fixes and reworked Netlink interface paul.moore
2006-09-21 16:57 ` [PATCH 1/6] NetLabel: correct improper handling of non-NetLabel peer contexts paul.moore
2006-09-21 18:08 ` James Morris
2006-09-21 18:28 ` Paul Moore
2006-09-21 16:57 ` [PATCH 2/6] NetLabel: make the CIPSOv4 cache spinlocks bottom half safe paul.moore
2006-09-21 16:57 ` [PATCH 3/6] NetLabel: change the SELinux permissions paul.moore
2006-09-21 16:57 ` [PATCH 4/6] NetLabel: rework the Netlink attribute handling (part 1) paul.moore
2006-09-25 9:12 ` Thomas Graf [this message]
2006-09-21 16:57 ` [PATCH 5/6] NetLabel: rework the Netlink attribute handling (part 2) paul.moore
2006-09-25 9:43 ` Thomas Graf
2006-09-25 14:13 ` Paul Moore
2006-09-25 15:06 ` Thomas Graf
2006-09-25 15:42 ` Paul Moore
2006-09-21 16:57 ` [PATCH 6/6] NetLabel: update docs with website information paul.moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925091235.GN18349@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=jmorris@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@epoch.ncsc.mil \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).