From: linas@austin.ibm.com (Linas Vepstas)
To: Auke Kok <sofar@foo-projects.org>
Cc: jesse.brandeburg@intel.com, netdev@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
akpm@osdl.org
Subject: [PATCH]: e1000: Janitor: Use #defined values for literals
Date: Mon, 25 Sep 2006 17:30:50 -0500 [thread overview]
Message-ID: <20060925223050.GC4518@austin.ibm.com> (raw)
Resending a minor janitorial patch from long ago that seems to have
fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1.
Please apply and forward upstream.
--linas
[PATCH]: e1000: Janitor: Use #defined values for literals
Minor janitorial patch: use #defines for literal values.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
----
drivers/net/e1000/e1000_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.18-mm1/drivers/net/e1000/e1000_main.c
===================================================================
--- linux-2.6.18-mm1.orig/drivers/net/e1000/e1000_main.c 2006-09-25 17:23:32.000000000 -0500
+++ linux-2.6.18-mm1/drivers/net/e1000/e1000_main.c 2006-09-25 17:23:51.000000000 -0500
@@ -4986,8 +4986,8 @@ static pci_ers_result_t e1000_io_slot_re
}
pci_set_master(pdev);
- pci_enable_wake(pdev, 3, 0);
- pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */
+ pci_enable_wake(pdev, PCI_D3hot, 0);
+ pci_enable_wake(pdev, PCI_D3cold, 0);
/* Perform card reset only on one instance of the card */
if (PCI_FUNC (pdev->devfn) != 0)
next reply other threads:[~2006-09-25 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 22:30 Linas Vepstas [this message]
2006-09-25 23:13 ` [PATCH]: e1000: Janitor: Use #defined values for literals Auke Kok
-- strict thread matches above, loose matches on Subject: below --
2006-08-07 20:16 Linas Vepstas
2006-08-07 20:21 ` Auke Kok
2006-08-07 20:29 ` Jeff Garzik
2006-06-23 16:36 Linas Vepstas
2006-06-23 18:07 ` Auke Kok
2006-06-23 20:07 ` Auke Kok
2006-06-23 21:12 ` Linas Vepstas
2006-06-27 17:32 ` Linas Vepstas
2006-06-27 18:03 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925223050.GC4518@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=sofar@foo-projects.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).