From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: paul.moore@hp.com, netdev@vger.kernel.org,
linux-audit@redhat.com, eparis@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/1] NetLabel: add audit support for configuration changes
Date: Thu, 28 Sep 2006 14:51:56 -0700 (PDT) [thread overview]
Message-ID: <20060928.145156.110116847.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0609281547060.28120@d.namei>
From: James Morris <jmorris@namei.org>
Date: Thu, 28 Sep 2006 15:50:42 -0400 (EDT)
>
> > +struct audit_buffer *netlbl_audit_start_common(int type, u32 secid)
>
> > + if (current->mm) {
> > + down_read(¤t->mm->mmap_sem);
> > + vma = current->mm->mmap;
> > + while (vma) {
> > + if ((vma->vm_flags & VM_EXECUTABLE) &&
> > + vma->vm_file) {
> > + audit_log_d_path(audit_buf,
> > + " exe=",
> > + vma->vm_file->f_dentry,
> > + vma->vm_file->f_vfsmnt);
> > + break;
> > + }
> > + vma = vma->vm_next;
> > + }
> > + up_read(¤t->mm->mmap_sem);
>
>
> Suggestion for the future: I think it'd be wortwhile consolidating this
> with the code in audit_log_task_info().
>
> In any case, the patch looks fine to me.
>
> Acked-by: James Morris <jmorris@namei.org>
Applied, thanks a lot.
next prev parent reply other threads:[~2006-09-28 21:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060928180326.896170000@hp.com>
2006-09-28 18:03 ` [PATCH 1/1] NetLabel: add audit support for configuration changes paul.moore
2006-09-28 19:50 ` James Morris
2006-09-28 20:04 ` Paul Moore
2006-09-28 20:10 ` James Morris
2006-09-28 21:25 ` Paul Moore
2006-09-28 21:51 ` David Miller [this message]
2006-09-29 14:08 ` Steve Grubb
2006-09-29 14:13 ` James Morris
2006-09-29 15:43 ` Paul Moore
2006-09-29 18:09 ` Paul Moore
2006-09-29 18:35 ` Steve Grubb
2006-09-29 20:28 ` Paul Moore
2006-09-29 21:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928.145156.110116847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-audit@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).