From: David Miller <davem@davemloft.net>
To: auke-jan.h.kok@intel.com
Cc: shemminger@osdl.org, jgarzik@pobox.com, netdev@vger.kernel.org,
jesse.brandeburg@intel.com
Subject: Re: [RFC] let mortals use ethtool
Date: Thu, 28 Sep 2006 14:53:45 -0700 (PDT) [thread overview]
Message-ID: <20060928.145345.90823467.davem@davemloft.net> (raw)
In-Reply-To: <451C28E9.6040708@intel.com>
From: Auke Kok <auke-jan.h.kok@intel.com>
Date: Thu, 28 Sep 2006 12:56:25 -0700
> PHYS_ID pokes in hardware and makes it jump through hoops, in the case of some hardware
> this could create a local DOS attack (e1000 suffers fromt his, probably more if not all)
> where the NIC might stop receiving packets, or the big lock is help indefinately.
>
> Not a good idea
>
> The other ones are fine I think.
I've applied Stephen's patch with PHYS_ID removed from the
allowed list, thanks for the feedback.
next prev parent reply other threads:[~2006-09-28 21:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 19:25 [RFC] let mortals use ethtool Stephen Hemminger
2006-09-28 19:53 ` James Morris
2006-09-28 20:43 ` Jeff Garzik
2006-09-28 19:56 ` Auke Kok
2006-09-28 21:53 ` David Miller [this message]
2006-09-28 22:03 ` Michael Chan
2006-09-28 22:22 ` David Miller
2006-09-28 20:17 ` Michael Chan
2006-09-28 20:28 ` Jeff Garzik
2006-09-28 20:32 ` James Morris
2006-09-28 20:35 ` Jeff Garzik
2006-09-28 20:39 ` Michael Chan
2006-09-28 22:16 ` David Miller
2006-09-28 22:30 ` Jeff Garzik
2006-09-28 22:13 ` David Miller
2006-09-28 22:25 ` Jeff Garzik
2006-09-28 22:33 ` David Miller
2006-09-28 20:23 ` Jeff Garzik
2006-09-28 22:15 ` David Miller
2006-09-28 22:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928.145345.90823467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).