From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Buesch Subject: Re: [PATCH] softmac: Fix WX and association related races Date: Thu, 28 Sep 2006 16:43:04 +0200 Message-ID: <200609281643.04631.mb@bu3sch.de> References: <200609271726.34305.mb@bu3sch.de> <1159453641.2648.20.camel@ux156> <1159454237.2642.17.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Larry Finger , linville@tuxdriver.com, netdev@vger.kernel.org, Johannes Berg Return-path: Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:45475 "EHLO bu3sch.de") by vger.kernel.org with ESMTP id S1161155AbWI1OnN (ORCPT ); Thu, 28 Sep 2006 10:43:13 -0400 To: Dan Williams In-Reply-To: <1159454237.2642.17.camel@localhost.localdomain> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday 28 September 2006 16:37, Dan Williams wrote: > On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > > On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrote: > > > > > I'd buy that argument. When the driver gets the deauth message, > > > shouldn't it be sending an IWAP 00:00:00:00:00:00 wireless event to > > > userspace? > > > > I thought we did that since a long time now, didn't you actually develop > > the initial patch? > > Yes, I think I did. My point here wasn't that the driver is _not_ > sending those messages (it almost certainly is), but what's _implied_ by > those messages. Namely that, if you're using a tool like wpa_supplicant > and/or NM, when you get a deauth from the AP and send the IWAP event, > all bets are off because the tool will likely override whatever the > driver thinks its doing. > > I'm somewhat ambiguous on just how much policy a driver should try to > enforce. I guess I'm OK with reassociation with the _same_ credentials. > But what airo does with "auto_wep" is very nearly, if not completely, > crossing the line [1]. The real question is, how much should drivers > really do, and how much should they leave to userspace? IMO a driver should implement absolutely _zero_ policy, as this is the only way to get the same (default) policy for different cards. A driver should _only_ provide generic events for userspace tools to make decisions. A "I got a deauth" event is really enough for userspace to know what to do. > Dan > > [1] if the auth mode (open or shared-key) doesn't work, airo schedules a > timer and bumps the auth mode to the other one automatically, and tries > reassociation. > > > -- Greetings Michael.